Skip to content

Include stdsimd in rust-src component #48736

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Mar 5, 2018

Conversation

alexcrichton
Copy link
Member

Closes #48734

@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 4, 2018

📌 Commit 2f2ac9a has been approved by petrochenkov

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 4, 2018
@petrochenkov
Copy link
Contributor

petrochenkov commented Mar 4, 2018

@bors p=3
Unbreaking no_std ecosystem.

@bors
Copy link
Collaborator

bors commented Mar 4, 2018

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Collaborator

bors commented Mar 4, 2018

📌 Commit 2f2ac9a has been approved by 3

@bors
Copy link
Collaborator

bors commented Mar 4, 2018

⌛ Testing commit 2f2ac9a with merge e2746d8...

bors added a commit that referenced this pull request Mar 4, 2018
Include stdsimd in rust-src component

Closes #48734
@bdrewery
Copy link
Contributor

bdrewery commented Mar 4, 2018

📌 Commit 2f2ac9a has been approved by 3

This seems weird?

@est31
Copy link
Member

est31 commented Mar 4, 2018

I guess @petrochenkov originally had sth like @bors r=3 and then edited their comment to read p=3. It can be fixed by doing @bors r=petrochenkov.

@bors
Copy link
Collaborator

bors commented Mar 4, 2018

@est31: 🔑 Insufficient privileges: Not in reviewers

1 similar comment
@bors
Copy link
Collaborator

bors commented Mar 4, 2018

@est31: 🔑 Insufficient privileges: Not in reviewers

@est31
Copy link
Member

est31 commented Mar 4, 2018

aargh I thought that `` makes bors not parse it as a command. I was wrong. Sorry for the spam :).

@bors
Copy link
Collaborator

bors commented Mar 5, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: 3
Pushing e2746d8 to master...

@bors bors merged commit 2f2ac9a into rust-lang:master Mar 5, 2018
@alexcrichton alexcrichton deleted the fix-rust-src branch March 19, 2018 17:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants