Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Stabilize option_ref_mut_cloned #48787

Merged
merged 1 commit into from
Mar 8, 2018
Merged

Stabilize option_ref_mut_cloned #48787

merged 1 commit into from
Mar 8, 2018

Conversation

mbrubeck
Copy link
Contributor

@mbrubeck mbrubeck commented Mar 6, 2018

Closes #43738.

@rust-highfive
Copy link
Contributor

r? @joshtriplett

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 6, 2018
@kennytm kennytm added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Mar 6, 2018
@joshtriplett
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 6, 2018

📌 Commit 0539613 has been approved by joshtriplett

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 6, 2018
@Aaron1011
Copy link
Member

The doc comment for that function still contains the #[feature] attribute, under the Examples heading:

     /// #![feature(option_ref_mut_cloned)]
     /// let mut x = 12;

Since the feature is being stabilized, I believe that should be removed.

@mbrubeck
Copy link
Contributor Author

mbrubeck commented Mar 6, 2018

The doc comment for that function still contains the #[feature] attribute

Fixed, thanks. r? @joshtriplett

@joshtriplett
Copy link
Member

Good catch, thank you!

@joshtriplett
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 6, 2018

📌 Commit d04362f has been approved by joshtriplett

@Centril Centril added the relnotes Marks issues that should be documented in the release notes of the next release. label Mar 7, 2018
@alexcrichton
Copy link
Member

@bors: rollup

@alexcrichton alexcrichton mentioned this pull request Mar 7, 2018
Merged
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 7, 2018
@alexcrichton
Rollup merge of rust-lang#48787 - mbrubeck:cloned, r=joshtriplett
2e9f960 
Stabilize option_ref_mut_cloned

Closes rust-lang#43738.
bors added a commit that referenced this pull request Mar 7, 2018
@bors
Auto merge of #48806 - alexcrichton:rollup, r=alexcrichton
6675913 
Rollup of 9 pull requests

- Successful merges: #48511, #48549, #48618, #48624, #48651, #48698, #48778, #48787, #48802
- Failed merges: #48669, #48710
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 7, 2018
@alexcrichton
Rollup merge of rust-lang#48787 - mbrubeck:cloned, r=joshtriplett
05ebc19 
Stabilize option_ref_mut_cloned

Closes rust-lang#43738.
bors added a commit that referenced this pull request Mar 7, 2018
@bors
Auto merge of #48806 - alexcrichton:rollup, r=alexcrichton
29d7fc1 
Rollup of 9 pull requests

- Successful merges: #48511, #48549, #48618, #48624, #48651, #48698, #48778, #48787, #48802
- Failed merges: #48669, #48710
bors added a commit that referenced this pull request Mar 7, 2018
@bors
Auto merge of #48806 - alexcrichton:rollup, r=alexcrichton
5430c0c 
Rollup of 9 pull requests

- Successful merges: #48511, #48549, #48618, #48624, #48651, #48698, #48778, #48787, #48802
- Failed merges: #48669, #48710
@alexcrichton alexcrichton merged commit d04362f into rust-lang:master Mar 8, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@joshtriplett joshtriplett joshtriplett approved these changes

Assignees

@joshtriplett joshtriplett

Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mbrubeck @rust-highfive @joshtriplett @bors @Aaron1011 @alexcrichton @kennytm @Centril