Skip to content

Update stdsimd module #48887

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Mar 13, 2018
Merged

Update stdsimd module #48887

merged 1 commit into from
Mar 13, 2018

Conversation

alexcrichton
Copy link
Member

Pulls in a redesigned std::simd module as well as a replacement for the
is_target_feature_detected! macro

@rust-highfive
Copy link
Contributor

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member Author

cc @gnzlbg

r? @kennytm

@rust-highfive rust-highfive assigned kennytm and unassigned aturon Mar 9, 2018
@pietroalbini pietroalbini added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 9, 2018
@kennytm
Copy link
Member

kennytm commented Mar 10, 2018

You need to add #![feature(fn_must_use, doc_cfg)] to coresimd.

[00:24:45] warning: `#[must_use]` on methods is experimental (see issue #43302)
[00:24:45]    --> libcore/../stdsimd/coresimd/ppsv/api/minimal.rs:76:13
[00:24:45]     |
[00:24:45] 76  |               #[must_use = "replace_unchecked does not modify the original value - it returns a new vector with the value at `index` replaced by `new_value`d"]
[00:24:45]     |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[00:24:45]     | 
[00:24:45]    ::: libcore/../stdsimd/coresimd/ppsv/v512.rs:124:1
[00:24:45]     |
[00:24:45] 124 | / simd_f_ty! {
[00:24:45] 125 | |     f64x8: 8, f64, b8x8, f64x8_tests |
[00:24:45] 126 | |     f64, f64, f64, f64, f64, f64, f64, f64 |
[00:24:45] 127 | |     x0, x1, x2, x3, x4, x5, x6, x7 |
[00:24:45] 128 | |     /// A 512-bit vector with 8 `f64` lanes.
[00:24:45] 129 | | }
[00:24:45]     | |_- in this macro invocation
[00:24:45]     |
[00:24:45]     = help: add #![feature(fn_must_use)] to the crate attributes to enable
[00:24:45] 
[00:24:45] error[E0658]: #[doc(cfg(...))] is experimental (see issue #43781)
[00:24:45]   --> libcore/../stdsimd/coresimd/mod.rs:52:5
[00:24:45]    |
[00:24:45] 52 |     #[doc(cfg(target_arch = "x86_64"))]
[00:24:45]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[00:24:45]    |
[00:24:45]    = help: add #![feature(doc_cfg)] to the crate attributes to enable
[00:24:45] 
[00:24:45]    Compiling alloc_jemalloc v0.0.0 (file:///checkout/src/liballoc_jemalloc)
[00:24:45] error: aborting due to previous error

@kennytm kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 10, 2018
@alexcrichton
Copy link
Member Author

Ah indeed! Running a build locally as well...

@kennytm kennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 10, 2018
@gnzlbg
Copy link
Contributor

gnzlbg commented Mar 10, 2018

@alexcrichton is there a way to add a build bot to stdsimd that does a sanity check for these things?

If it takes too long to run we could just allow it to fail, and only try to make it pass before updating rust upstream.

@kennytm
Copy link
Member

kennytm commented Mar 10, 2018

Travis passed, so

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 10, 2018

📌 Commit 4163c4a has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 10, 2018
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Mar 10, 2018
Update stdsimd module

Pulls in a redesigned `std::simd` module as well as a replacement for the
`is_target_feature_detected!` macro
@alexcrichton
Copy link
Member Author

@bors: r=kennytm

cc @QuietMisdreavus had to back out rust-lang/stdarch#367 due to #48912 (comment)

@bors
Copy link
Collaborator

bors commented Mar 10, 2018

📌 Commit 512bafe has been approved by kennytm

@alexcrichton
Copy link
Member Author

@gnzlbg

is there a way to add a build bot to stdsimd that does a sanity check for these things?

Perhaps yeah but everything's changing a rapid enough pace right now it's probably best to figure these things out at integration time rather than slowing down either portion

@bors
Copy link
Collaborator

bors commented Mar 11, 2018

⌛ Testing commit 512bafe0afddee957431c45eb83e4ee76734da79 with merge 351cb6006cfa7c6eefd8806b5c21a7503eb45594...

@bors
Copy link
Collaborator

bors commented Mar 11, 2018

💔 Test failed - status-travis

@bors bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 11, 2018
@bors bors added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 11, 2018
@kennytm kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 11, 2018
Pulls in a redesigned `std::simd` module as well as a replacement for the
`is_target_feature_detected!` macro
@alexcrichton
Copy link
Member Author

@bors: r=kennytm

@bors
Copy link
Collaborator

bors commented Mar 11, 2018

📌 Commit f2a8556 has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 11, 2018
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Mar 12, 2018
Update stdsimd module

Pulls in a redesigned `std::simd` module as well as a replacement for the
`is_target_feature_detected!` macro
@bors
Copy link
Collaborator

bors commented Mar 12, 2018

⌛ Testing commit f2a8556 with merge d12e1565ccec8e13f8e5e4cbbf84e825daea80ea...

@bors
Copy link
Collaborator

bors commented Mar 12, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 12, 2018
@kennytm
Copy link
Member

kennytm commented Mar 12, 2018

@bors retry

A spurious bug that should be fixed by #48938.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 12, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Mar 12, 2018
Update stdsimd module

Pulls in a redesigned `std::simd` module as well as a replacement for the
`is_target_feature_detected!` macro
bors added a commit that referenced this pull request Mar 12, 2018
Rollup of 13 pull requests

- Successful merges: #48201, #48705, #48725, #48824, #48877, #48880, #48887, #48928, #48934, #48480, #48631, #48898, #48954
- Failed merges:
@bors bors merged commit f2a8556 into rust-lang:master Mar 13, 2018
@alexcrichton alexcrichton deleted the update-stdsimd branch March 19, 2018 17:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants