Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Cache the specialization_graph query #49004

Merged
merged 1 commit into from
Mar 20, 2018
Merged

Cache the specialization_graph query #49004

merged 1 commit into from
Mar 20, 2018

Conversation

wesleywiser
Copy link
Member

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 14, 2018
@michaelwoerister
Copy link
Member

Perfect! :)

@bors try

@bors
Copy link
Contributor

bors commented Mar 14, 2018

⌛ Trying commit 311bb10 with merge e744f7e...

bors added a commit that referenced this pull request Mar 14, 2018
@bors
Auto merge of #49004 - wesleywiser:incr_specialization_graph_query, r…
e744f7e 
…=<try>

Cache the specialization_graph query

Fixes #48987

r? @michaelwoerister
@bors
Copy link
Contributor

bors commented Mar 14, 2018

☀️ Test successful - status-travis
State: approved= try=True

@michaelwoerister
Copy link
Member

@Mark-Simulacrum, could you do a perf-run please? Just to make sure this doesn't regress anything.

@Mark-Simulacrum
Copy link
Member

Perf started.

@michaelwoerister
Copy link
Member

Link: http://perf.rust-lang.org/compare.html?start=fab632f9759af4f3d96c6ec69e24e5428060dba4&end=e744f7efcbdd9caf5dafe6bfaa813fa6aaec2aba&stat=instructions%3Au

@wesleywiser wesleywiser force-pushed the incr_specialization_graph_query branch from 311bb10 to 5766e71 Compare March 15, 2018 01:02
@michaelwoerister
Copy link
Member

@Mark-Simulacrum, I think something has gone wrong with the perf-run.

@Mark-Simulacrum
Copy link
Member

I've added even more debugging and restarted it.. not sure what went wrong.

@michaelwoerister
Copy link
Member

michaelwoerister commented Mar 16, 2018 •
edited
Loading

Still doesn't work :(

@Mark-Simulacrum
Copy link
Member

Restarted again this time the logging is confirmed to work. Turns out env_logger doesn't send output to stdout...

@Mark-Simulacrum
Copy link
Member

It worked: http://perf.rust-lang.org/compare.html?start=fab632f9759af4f3d96c6ec69e24e5428060dba4&end=e744f7efcbdd9caf5dafe6bfaa813fa6aaec2aba&stat=instructions%3Au.

No ideas on what went wrong before, but I guess we at least have logging now.

@michaelwoerister
Copy link
Member

Thanks @Mark-Simulacrum!

The results are not spectacular but pretty much in line with what I expected.

@bors r+

@bors
Copy link
Contributor

bors commented Mar 19, 2018

📌 Commit 5766e71 has been approved by michaelwoerister

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 19, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Mar 19, 2018
@kennytm
Rollup merge of rust-lang#49004 - wesleywiser:incr_specialization_gra…
28eced1 
…ph_query, r=michaelwoerister

Cache the specialization_graph query

Fixes rust-lang#48987

r? @michaelwoerister
@kennytm kennytm mentioned this pull request Mar 19, 2018
Merged
bors added a commit that referenced this pull request Mar 20, 2018
@bors
Auto merge of #49190 - kennytm:rollup, r=kennytm
75af15e 
Rollup of 17 pull requests

- Successful merges: #46518, #48810, #48834, #48902, #49004, #49092, #49096, #49099, #49104, #49125, #49139, #49152, #49157, #49161, #49166, #49176, #49184
- Failed merges:
@bors bors merged commit 5766e71 into rust-lang:master Mar 20, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@michaelwoerister michaelwoerister

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wesleywiser @michaelwoerister @bors @Mark-Simulacrum @rust-highfive