Skip to content

Allow test target to pass without installing #49140

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 22, 2018
Merged

Allow test target to pass without installing #49140

merged 1 commit into from
Mar 22, 2018

Conversation

semarie
Copy link
Contributor

@semarie semarie commented Mar 18, 2018

explicitly pass -L target-lib to rustdoc

on OpenBSD, without it, it fails on several tests with:

error[E0463]: can't find crate for `std`

@semarie
Allow test target to pass without installing
e269a74 
explicitly pass -L target-lib to rustdoc
@pietroalbini pietroalbini added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 19, 2018
@pietroalbini
Copy link
Member

Thanks for this PR! Highfive failed to assign a reviewer.

r? @Mark-Simulacrum

@bors
Copy link
Collaborator

bors commented Mar 19, 2018

@pietroalbini: 🔑 Insufficient privileges: Not in reviewers

@Mark-Simulacrum
Copy link
Member

Going to go ahead and say r? @alexcrichton though it seems fine to me.

@alexcrichton
Copy link
Member

@bors: r+

Sure!

@bors
Copy link
Collaborator

bors commented Mar 20, 2018

📌 Commit e269a74 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 20, 2018
@kennytm kennytm mentioned this pull request Mar 21, 2018
Closed
kennytm added a commit to kennytm/rust that referenced this pull request Mar 21, 2018
@kennytm
Rollup merge of rust-lang#49140 - semarie:rustdoc-test-path, r=alexcr…
9a310a3 
…ichton

Allow test target to pass without installing

explicitly pass -L target-lib to rustdoc

on OpenBSD, without it, it fails on several tests with:
```
error[E0463]: can't find crate for `std`
```
@kennytm kennytm mentioned this pull request Mar 22, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this pull request Mar 22, 2018
@kennytm
Rollup merge of rust-lang#49140 - semarie:rustdoc-test-path, r=alexcr…
20eaf35 
…ichton

Allow test target to pass without installing

explicitly pass -L target-lib to rustdoc

on OpenBSD, without it, it fails on several tests with:
```
error[E0463]: can't find crate for `std`
```
bors added a commit that referenced this pull request Mar 22, 2018
@bors
Auto merge of #49264 - kennytm:rollup, r=kennytm
5092c6b 
Rollup of 23 pull requests

- Successful merges: #48374, #48596, #48759, #48939, #49029, #49069, #49093, #49109, #49117, #49140, #49158, #49188, #49189, #49209, #49211, #49216, #49225, #49231, #49234, #49242, #49244, #49105, #49038
- Failed merges:
@alexcrichton alexcrichton merged commit e269a74 into rust-lang:master Mar 22, 2018
@semarie semarie deleted the rustdoc-test-path branch March 23, 2018 05:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@semarie @pietroalbini @bors @Mark-Simulacrum @alexcrichton