Stabilize match_default_bindings #49394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rust-highfive
added
the
S-waiting-on-review
cramertj
force-pushed
the
stable-match-bindings
branch
from
dd98f84 to
1f6a313
Compare
cramertj
force-pushed
the
stable-match-bindings
branch
from
1f6a313 to
38520cf
Compare
|
@petrochenkov See my comment above-- these are both errors now, and I believe they could be made to not error in the future in a backwards-compatible way. |
|
☔ The latest upstream changes (presumably #49053) made this pull request unmergeable. Please resolve the merge conflicts. |
cramertj
force-pushed
the
stable-match-bindings
branch
from
38520cf to
578ab15
Compare
kennytm
reviewed
Mar 27, 2018
src/libsyntax/feature_gate.rs
Outdated
| @@ -563,6 +560,8 @@ declare_features! ( | |||
| (accepted, conservative_impl_trait, "1.26.0", Some(34511), None), | |||
| // The `i128` type | |||
| (accepted, i128_type, "1.26.0", Some(35118), None), | |||
| // Default match binding modes (RFC 2005) | |||
| (accepted, match_default_bindings, "1.22.0", Some(42640), None), | |||
There was a problem hiding this comment.
This should definitely not be 1.22.0...
cramertj
force-pushed
the
stable-match-bindings
branch
from
578ab15 to
d36eee1
Compare
|
@bors r+ |
|
📌 Commit d36eee1 has been approved by |
bors
added
S-waiting-on-bors
|
@bors p=15 |
cramertj
added
the
relnotes
bors
added a commit
that referenced
this pull request
Mar 27, 2018
Stabilize match_default_bindings This includes a submodule update to rustfmt in order to allow a stable feature declaration. r? @nikomatsakis cc #42640 Many of the tests this PR touches are merely testing the current lack of desired future behavior around #44849 and #44848 (cc @tschottdorf). I noticed the bullets for those items were checked on the tracking issue-- I've unchecked them, as they don't appear to have been completed and I don't see any comments indicating that we don't want to pursue them further. Still, I think it's fine to stabilize the current behavior, as I think expanding it in the future should be backwards-compatible.
|
💔 Test failed - status-appveyor |
bors
added
S-waiting-on-review
|
@bors retry 3 hour timeout |
bors
added
S-waiting-on-bors
|
⌛ Testing commit d36eee1 with merge 7cd6ced665f481746902e12d9d5fd3da2ed314b3... |
|
💔 Test failed - status-appveyor |
bors
added
S-waiting-on-review
|
@cramertj I think you need to actually rebase. |
This includes a submodule update to rustfmt in order to allow a stable feature declaration.
cramertj
force-pushed
the
stable-match-bindings
branch
from
d36eee1 to
3c65f53
Compare
|
📌 Commit 3c65f53 has been approved by |
|
⌛ Testing commit 3c65f53 with merge 29b54f86dc2d61faf66686fc40cc7f11759ac7fa... |
|
💔 Test failed - status-travis |
bors
added
S-waiting-on-review
|
I will assume that this is spurious, but I suppose we should also cc @BurntSushi. @bors retry |
bors
added
S-waiting-on-bors
|
The xsv error is supposed to be fixed by BurntSushi/xsv@92de288 and #45550, not sure why this is coming back... |
|
@Mark-Simulacrum I would say that is definitely spurious. I'll try to take a closer look soonish, but not sure exactly when. |
bors
added a commit
that referenced
this pull request
Mar 28, 2018
Stabilize match_default_bindings This includes a submodule update to rustfmt in order to allow a stable feature declaration. r? @nikomatsakis cc #42640 Many of the tests this PR touches are merely testing the current lack of desired future behavior around #44849 and #44848 (cc @tschottdorf). I noticed the bullets for those items were checked on the tracking issue-- I've unchecked them, as they don't appear to have been completed and I don't see any comments indicating that we don't want to pursue them further. Still, I think it's fine to stabilize the current behavior, as I think expanding it in the future should be backwards-compatible.
|
☀️ Test successful - status-appveyor, status-travis |
This was referenced Apr 26, 2018
koba-e964
added a commit
to koba-e964/min-caml-rust
that referenced
this pull request
Jun 10, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a submodule update to rustfmt
in order to allow a stable feature declaration.
r? @nikomatsakis
cc #42640
Many of the tests this PR touches are merely testing the current lack of desired future behavior around #44849 and #44848 (cc @tschottdorf). I noticed the bullets for those items were checked on the tracking issue-- I've unchecked them, as they don't appear to have been completed and I don't see any comments indicating that we don't want to pursue them further. Still, I think it's fine to stabilize the current behavior, as I think expanding it in the future should be backwards-compatible.