Skip to content

Implement shrink_to method on collections #49400

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2018
Merged

Implement shrink_to method on collections #49400

merged 1 commit into from
Mar 29, 2018

Conversation

Diggsey
Copy link
Contributor

@Diggsey Diggsey commented Mar 26, 2018

Fixes #49385

@rust-highfive
Copy link
Contributor

r? @joshtriplett

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 26, 2018
@Diggsey Diggsey mentioned this pull request Mar 26, 2018
Merged
@joshtriplett joshtriplett added T-lang Relevant to the language team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-lang Relevant to the language team, which will review and decide on the PR/issue. labels Mar 27, 2018
@joshtriplett
Copy link
Member

This seems reasonable to me.

@rust-lang/libs, does this seem like something that needs an RFC before it goes in?

@Diggsey
Copy link
Contributor Author

Diggsey commented Mar 27, 2018

I would like some feedback on whether panicking is the best approach here. (In the event that the requested minimum capacity is larger than the current capacity).

@alexcrichton
Copy link
Member

@joshtriplett we're generally much more lax about unstable APIs, so this likely wouldn't require an RFC

@joshtriplett
Copy link
Member

@alexcrichton Ah, OK.

Will the examples in the documentation automatically get run as tests? If not, this definitely needs some new tests.

@sfackler
Copy link
Member

@joshtriplett they will be run, yeah.

@joshtriplett
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 28, 2018

📌 Commit 04f6692 has been approved by joshtriplett

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 28, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Mar 28, 2018
@kennytm
Rollup merge of rust-lang#49400 - Diggsey:shrink-to, r=joshtriplett
010fb40 
Implement `shrink_to` method on collections

Fixes rust-lang#49385
@kennytm kennytm mentioned this pull request Mar 28, 2018
Merged
bors added a commit that referenced this pull request Mar 28, 2018
@bors
Auto merge of #49460 - kennytm:rollup, r=kennytm
d52c44e 
Rollup of 12 pull requests

- Successful merges: #49243, #49329, #49364, #49400, #49405, #49427, #49428, #49429, #49439, #49442, #49444, #49452
- Failed merges:
@bors bors merged commit 04f6692 into rust-lang:master Mar 29, 2018
@Amanieu
Copy link
Member

Amanieu commented Oct 1, 2018

This is missing a tracking issue.

@Diggsey Diggsey deleted the shrink-to branch October 1, 2018 16:05
@ordovicia ordovicia mentioned this pull request Dec 2, 2018
Closed
3 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@joshtriplett joshtriplett

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Diggsey @rust-highfive @joshtriplett @alexcrichton @sfackler @bors @Amanieu