Fix anchors issue when everything is collapsed #49652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pietroalbini
added
the
S-waiting-on-review
|
I'm building some docs with this change, but it looks like this change makes it so that if the URL has an anchor, it doesn't auto-collapse a section that has that anchor in it? Just making sure. It looks good, but i'd like to poke around a rendering with it before giving an r+. |
|
@frewsxcv Here's a rendering on my server of docs with this change. If this works out for you, r=me. |
|
Cool! Let's get this rolling then. :D @bors r+ |
|
📌 Commit 238583a has been approved by |
bors
added
S-waiting-on-bors
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Apr 6, 2018
…QuietMisdreavus Fix anchors issue when everything is collapsed Fixes rust-lang#49455. @frewsxcv does it seem good for you like this? r? @QuietMisdreavus
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Apr 7, 2018
…QuietMisdreavus Fix anchors issue when everything is collapsed Fixes rust-lang#49455. @frewsxcv does it seem good for you like this? r? @QuietMisdreavus
bors
added a commit
that referenced
this pull request
Apr 7, 2018
Rollup of 9 pull requests Successful merges: - #49510 (Fix anchor position on fields) - #49652 (Fix anchors issue when everything is collapsed) - #49702 (std: Inline some Termination-related methods) - #49728 (add emit_debug_gdb_scripts target option and ..) - #49731 (add THUMB targets to rustup manifest) - #49742 (Using X headings instead of 0.X #49739) - #49748 (proc_macro: Improve Debug representations) - #49750 (bootstrap: Remove the fast path) - #49503 (Inject the `compiler_builtins` crate whenever the `core` crate is injected) Failed merges:
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49455.
@frewsxcv does it seem good for you like this?
r? @QuietMisdreavus