Skip to content

Compile LLVM with Clang on release builders #50200

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2018
Merged

Compile LLVM with Clang on release builders #50200

merged 1 commit into from
May 10, 2018

Conversation

alexcrichton
Copy link
Member

Attempting to cache in on some rustc compile time wins mentioned in #49879 (comment)

@alexcrichton

This comment has been minimized.

# to view
@bors

This comment has been minimized.

# to view
bors added a commit that referenced this pull request Apr 24, 2018
@bors
Auto merge of #50200 - alexcrichton:compile-with-clang, r=<try>
d9f1198 
WIP: Compile LLVM with Clang on release builders

Attempting to cache in on some rustc compile time wins mentioned in #49879 (comment)
@alexcrichton
Copy link
Member Author

Gonna run this through perf to see if we can verify the build improvements. Unfortunately I wasn't seeing much of an improvement locally, so I'm hoping that a more controlled environment like perf.r-l.o can show some better numbers perhaps.

@bors

This comment has been minimized.

# to view
@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Apr 24, 2018
@alexcrichton alexcrichton mentioned this pull request Apr 24, 2018
Closed
@rust-highfive

This comment has been minimized.

# to view
@matthiaskrgr

This comment has been minimized.

# to view
@mattico mattico mentioned this pull request Apr 24, 2018
Open
@michaelwoerister

This comment has been minimized.

# to view
@bors

This comment has been minimized.

# to view
@bors

This comment has been minimized.

# to view
@rust-highfive

This comment has been minimized.

# to view
@rust-highfive

This comment has been minimized.

# to view
@alexcrichton

This comment has been minimized.

# to view
@bors

This comment has been minimized.

# to view
@bors
Copy link
Collaborator

bors commented Apr 25, 2018

💔 Test failed - status-travis

@alexcrichton

This comment has been minimized.

# to view
@bors

This comment has been minimized.

# to view
@bors bors mentioned this pull request Apr 25, 2018
Merged
@bors

This comment has been minimized.

# to view
@rust-highfive

This comment has been minimized.

# to view
1 similar comment
@rust-highfive

This comment has been minimized.

# to view
@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 10, 2018
@rust-highfive

This comment has been minimized.

# to view
@rust-highfive

This comment has been minimized.

# to view
@alexcrichton
Copy link
Member Author

@bors: retry

No major slowdown from the previous successful run:

-  10.184 (  89.036 =>   78.852) Std { compiler: Compiler { stage: 2, host: "i686-unknown-linux-gnu" }, target: "i686-unknown-linux-gnu" }
-  12.257 (  62.006 =>   49.749) Docs { stage: 2, host: "i686-unknown-linux-gnu" }
+  13.271 ( 115.781 =>  129.052) Llvm { target: "i686-unknown-linux-gnu", emscripten: true }
-  13.744 (  79.546 =>   65.802) CodegenBackend { compiler: Compiler { stage: 1, host: "i686-unknown-linux-gnu" }, target: "i686-unknown-linux-gnu", backend: "emscripten" }
-  15.592 (  86.858 =>   71.266) CodegenBackend { compiler: Compiler { stage: 1, host: "i686-unknown-linux-gnu" }, target: "i686-unknown-linux-gnu", backend: "llvm" }
-  18.188 ( 168.000 =>  149.812) Rustc { compiler: Compiler { stage: 2, host: "i686-unknown-linux-gnu" } }
-  19.101 ( 252.878 =>  233.777) ToolBuild { compiler: Compiler { stage: 0, host: "i686-unknown-linux-gnu" }, target: "i686-unknown-linux-gnu", tool: "rustbook", path: "src/tools/rustbook", mode: Librustc, is_ext_tool: false, extra_features: [] }
-  29.137 ( 142.258 =>  113.121) Rustdoc { host: "i686-unknown-linux-gnu" }
+  32.046 ( 248.280 =>  280.326) Llvm { target: "i686-unknown-linux-gnu", emscripten: false }
-  50.573 ( 253.241 =>  202.668) ToolBuild { compiler: Compiler { stage: 2, host: "i686-unknown-linux-gnu" }, target: "i686-unknown-linux-gnu", tool: "rustfmt", path: "src/tools/rustfmt", mode: Librustc, is_ext_tool: true, extra_features: [] }
-  51.114 ( 244.849 =>  193.735) ToolBuild { compiler: Compiler { stage: 2, host: "i686-unknown-linux-gnu" }, target: "i686-unknown-linux-gnu", tool: "clippy-driver", path: "src/tools/clippy", mode: Librustc, is_ext_tool: true, extra_features: [] }
-  76.286 ( 414.507 =>  338.221) ToolBuild { compiler: Compiler { stage: 2, host: "i686-unknown-linux-gnu" }, target: "i686-unknown-linux-gnu", tool: "cargo", path: "src/tools/cargo", mode: Librustc, is_ext_tool: false, extra_features: [] }
-  77.728 (1076.627 =>  998.899) Rustc { target: "i686-unknown-linux-gnu", compiler: Compiler { stage: 0, host: "i686-unknown-linux-gnu" } }
-  80.869 ( 383.886 =>  303.017) ToolBuild { compiler: Compiler { stage: 2, host: "i686-unknown-linux-gnu" }, target: "i686-unknown-linux-gnu", tool: "rls", path: "src/tools/rls", mode: Librustc, is_ext_tool: true, extra_features: ["clippy"] }
- 218.144 (1203.306 =>  985.162) Rustc { target: "i686-unknown-linux-gnu", compiler: Compiler { stage: 1, host: "i686-unknown-linux-gnu" } }
- 358.084 ( 358.084 =>    0.000) Extended { stage: 2, host: "i686-unknown-linux-gnu", target: "i686-unknown-linux-gnu" }
- 432.515 ( 432.515 =>    0.000) PlainSourceTarball

otherwise I think the new docker image just took awhile to build

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 10, 2018
@bors
Copy link
Collaborator

bors commented May 10, 2018

⌛ Testing commit 7e5b9ac with merge 2a1af97...

bors added a commit that referenced this pull request May 10, 2018
@bors
Auto merge of #50200 - alexcrichton:compile-with-clang, r=kennytm
2a1af97 
Compile LLVM with Clang on release builders

Attempting to cache in on some rustc compile time wins mentioned in #49879 (comment)
@bors
Copy link
Collaborator

bors commented May 10, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 10, 2018
@rust-highfive

This comment has been minimized.

# to view
@rust-highfive

This comment has been minimized.

# to view
@kennytm
Copy link
Member

kennytm commented May 10, 2018

@bors retry

3 hour timeout.

Step Duration
stage1-rustc 37min
stage0-rustc 24min
run-pass 14min
run-pass-fulldeps 9min
plain source tarball 8min
test/core 6min
llvm 6min
another llvm 🤔 5min
test/std 5min
stage0-rustbook 5min

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 10, 2018
@bors
Copy link
Collaborator

bors commented May 10, 2018

⌛ Testing commit 7e5b9ac with merge 57dc984...

bors added a commit that referenced this pull request May 10, 2018
@bors
Auto merge of #50200 - alexcrichton:compile-with-clang, r=kennytm
57dc984 
Compile LLVM with Clang on release builders

Attempting to cache in on some rustc compile time wins mentioned in #49879 (comment)
@bors
Copy link
Collaborator

bors commented May 10, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: kennytm
Pushing 57dc984 to master...

@bors bors merged commit 7e5b9ac into rust-lang:master May 10, 2018
This was referenced May 10, 2018
Merged
Closed
Merged
Merged
@michaelwoerister
Copy link
Member

🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉 (one for each failed bors run)

@alexcrichton alexcrichton deleted the compile-with-clang branch May 10, 2018 14:00
@alexcrichton
Copy link
Member Author

omg it worked!

@michaelwoerister
Copy link
Member

The results for small crates are pretty spectacular and for larger crates they are rather good too:
http://perf.rust-lang.org/compare.html?start=95d0b9e96795aea20ac4a1fad9251982714d3c55&end=0a223d139cd26e5bfab23a478a5cad845eaab131&stat=wall-time

Thanks for all the work all of you have put into this PR!

@scottmcm
Copy link
Member

Wow! That's an impressive amount of green!

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@kennytm kennytm

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@alexcrichton @bors @rust-highfive @matthiaskrgr @michaelwoerister @ishitatsuyuki @Mark-Simulacrum @kennytm @mati865 @scottmcm