Skip to content

Make String::new() const #50460

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
May 9, 2018
Merged

Make String::new() const #50460

merged 1 commit into from
May 9, 2018

Conversation

F001
Copy link
Contributor

@F001 F001 commented May 5, 2018

Following the steps of #50233 , make String::new() a const fn.

@rust-highfive
Copy link
Contributor

r? @kennytm

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 5, 2018
@kennytm kennytm added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label May 5, 2018
@kennytm
Copy link
Member

kennytm commented May 5, 2018

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 5, 2018

📌 Commit 160063a has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 5, 2018
@pietroalbini pietroalbini added the relnotes Marks issues that should be documented in the release notes of the next release. label May 7, 2018
@kennytm kennytm removed the relnotes Marks issues that should be documented in the release notes of the next release. label May 8, 2018
@kennytm
Copy link
Member

kennytm commented May 8, 2018

@pietroalbini This doesn't need relnotes yet because this is still unstable.

kennytm added a commit to kennytm/rust that referenced this pull request May 9, 2018
Make `String::new()` const

Following the steps of rust-lang#50233 , make `String::new()` a `const fn`.
bors added a commit that referenced this pull request May 9, 2018
Rollup of 11 pull requests

Successful merges:

 - #49988 (Mention Result<!, E> in never docs.)
 - #50148 (turn `ManuallyDrop::new` into a constant function)
 - #50456 (Update the Cargo submodule)
 - #50460 (Make `String::new()` const)
 - #50464 (Remove some transmutes)
 - #50505 (Added regression function match value test)
 - #50511 (Add some explanations for #[must_use])
 - #50525 (Optimize string handling in lit_token().)
 - #50527 (Cleanup a `use` in a raw_vec test)
 - #50539 (Add more logarithm constants)
 - #49523 (Update RELEASES.md for 1.26.0)

Failed merges:
@bors bors merged commit 160063a into rust-lang:master May 9, 2018
@F001 F001 deleted the const_string branch August 28, 2018 10:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants