-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Rename trans to codegen everywhere. #50615
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
☔ The latest upstream changes (presumably #50611) made this pull request unmergeable. Please resolve the merge conflicts. |
cc @michaelwoerister on the choice of "mono(morphization) item" to replace "trans item". |
The naming changes are fine by me. |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
☔ The latest upstream changes (presumably #50648) made this pull request unmergeable. Please resolve the merge conflicts. |
r=me |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
@bors r=nikomatsakis p=100 (high chance to bitrot) |
📌 Commit 76b94d7 has been approved by |
⌛ Testing commit 76b94d7b3cfe7786a049c40482a875374b240447 with merge dffc5884ba0b30c01753292c69f5d39a3481736e... |
💔 Test failed - status-appveyor |
Cargo test failed. Please either keep the
|
@kennytm This is just a test of passing flags to |
@eddyb The test was added recently by rust-lang/cargo#5393 (cc @smithsps). I don't know if this tests core cargo functionality 🙃 This test case is the only place the word "trans" appear in cargo. |
@kennytm it was actually committed in 2015 rust-lang/cargo@8230f1f But it looks like I did something funky with the history when I added a test above that one. |
@eddyb yeah it's fine to fix cargo to either remove that test, change the syntax, or otherwise just pass a different flag to avoid this issue altogether |
@kennytm oh ya it should be good to remove, looks like I accidentally added it back in, it was removed by @matklad in rust-lang/cargo@14067b9#diff-8a47d5cf44a09ccf3037cdc48c9d4933 |
Tested on commit rust-lang/rust@dbd10f8. Direct link to PR: <rust-lang/rust#50615> 💔 rls on windows: test-pass → build-fail (cc @nrc, @rust-lang/infra). 💔 rls on linux: test-pass → build-fail (cc @nrc, @rust-lang/infra).
RLS breakage should be mititgated at rust-dev-tools/rls-rustc#8 and rust-lang/rls#872 |
Rebase of rust-lang#50783 has accidentally revived the flag (which should be renamed to `-Z codegen-time-graph` by rust-lang#50615).
Remove the unused `-Z trans-time-graph` flag. Rebase of rust-lang#50783 has accidentally revived the flag (which should be renamed to `-Z codegen-time-graph` by rust-lang#50615).
Part of #45274.