Require type is sized in wfcheck.check_item_type for externed DSTs, c…

[krk]

Closes #36122

Continuing #50126.

[rust-highfive]

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

[krk]

r? @petrochenkov

[rust-highfive]

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:05:03] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:05:03] tidy error: /checkout/src/test/compile-fail/issue-36122.rs:14: line longer than 100 chars
[00:05:04] tidy error: /checkout/src/librustc_typeck/check/wfcheck.rs:154: trailing whitespace
[00:05:04] tidy error: /checkout/src/librustc_typeck/check/wfcheck.rs:334: trailing whitespace
[00:05:04] tidy error: /checkout/src/librustc_typeck/check/wfcheck.rs:339: trailing whitespace
[00:05:05] some tidy checks failed
[00:05:05] 
[00:05:05] 
[00:05:05] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:05:05] 
[00:05:05] 
[00:05:05] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:05:05] Build completed unsuccessfully in 0:01:45
[00:05:05] Build completed unsuccessfully in 0:01:45
[00:05:05] Makefile:79: recipe for target 'tidy' failed
[00:05:05] make: *** [tidy] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:0126aa21
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:0fa342c4:start=1530178018744503118,finish=1530178018751592044,duration=7088926
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:05a32146
$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
head: cannot open ‘./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers’ for reading: No such file or directory
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0487295c
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

[petrochenkov]

Thanks!
@bors r+

[bors]

📌 Commit fb58db4 has been approved by petrochenkov

[bors]

⌛ Testing commit fb58db4 with merge d1a43163e1d50646cfa940476210ae10c86d88c1...

[bors]

💔 Test failed - status-appveyor

[kennytm]

Legit, you need to fix a cargo #![no_core] test first.

---- doc::doc_target stdout ----
running `C:\projects\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\release\cargo.exe doc --target arm-unknown-linux-gnueabihf --verbose`
thread 'doc::doc_target' panicked at '
Expected: execs
    but: exited with exit code: 101
--- stdout
--- stderr
 Documenting foo v0.0.1 (file:///C:/projects/rust/build/x86_64-pc-windows-msvc/stage2-tools/x86_64-pc-windows-msvc/cit/t484/foo)
     Running `rustdoc --crate-name foo src\lib.rs --target arm-unknown-linux-gnueabihf -o C:\projects\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\cit\t484\foo\target\arm-unknown-linux-gnueabihf\doc -L dependency=C:\projects\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\cit\t484\foo\target\arm-unknown-linux-gnueabihf\debug\deps -L dependency=C:\projects\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\cit\t484\foo\target\debug\deps`
error: requires `sized` lang_item
error: Could not document `foo`.
Caused by:
  process didn't exit successfully: `rustdoc --crate-name foo src\lib.rs --target arm-unknown-linux-gnueabihf -o C:\projects\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\cit\t484\foo\target\arm-unknown-linux-gnueabihf\doc -L dependency=C:\projects\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\cit\t484\foo\target\arm-unknown-linux-gnueabihf\debug\deps -L dependency=C:\projects\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\cit\t484\foo\target\debug\deps` (exit code: 101)
', tools\cargo\tests\testsuite\hamcrest.rs:13:9
note: Run with `RUST_BACKTRACE=1` for a backtrace.
failures:
    doc::doc_target
test result: FAILED. 1310 passed; 1 failed; 4 ignored; 0 measured; 0 filtered out

[krk]

@kennytm Thank you for the details. I do not understand which test is failing, how can I isolate it from the cargotest? I could not find references to cit/t484/foo in the code.

[kennytm]

@krk the test is in https://github.com/rust-lang/cargo/blob/94f7058a483b05ad742da5efb66dd1c2d4b8619c/tests/testsuite/doc.rs#L762-L802

[pietroalbini]

Ping from triage @krk! Did you make any progress fixing the failing test?

[bors]

☔ The latest upstream changes (presumably #52264) made this pull request unmergeable. Please resolve the merge conflicts.

[stokhos]

Ping from triage @krk! it has been a while since the last time we heard from you, will you have time to work on this PR?

[pietroalbini]

Thank you for this PR @krk! Unfortunately we haven't heard from you on this in a while, so I'm closing the PR to keep things tidy. Don't worry though, if you'll have time again in the future please reopen this PR, we'll be happy to review it again!