Emit column info in debuginfo for non msvc like targets #51980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
Could a test be added for this? |
|
@alexcrichton no idea how to get tests out of this using lldb or gdb, which the debuginfo tests rely on. The only place lldb exposes column info that I am aware of is in underlining the column: https://reviews.llvm.org/rL282105 I could create something using gimli/addr2line but not sure if we want to add it for the test harness just for that :). |
|
Note that this underlining happens using ANSI control characters. It's not like rustc's span rendering. |
|
@bors: r+ Ok in that case seems fine to leave this as-is |
|
📌 Commit 3779a4c has been approved by |
bors
added
S-waiting-on-bors
pietroalbini
added a commit
to pietroalbini/rust
that referenced
this pull request
Jul 3, 2018
Emit column info in debuginfo for non msvc like targets Fixes rust-lang#42921 everywhere except MSVC. This mimics clang behaviour.
pietroalbini
added a commit
to pietroalbini/rust
that referenced
this pull request
Jul 3, 2018
Emit column info in debuginfo for non msvc like targets Fixes rust-lang#42921 everywhere except MSVC. This mimics clang behaviour.
bors
added a commit
that referenced
this pull request
Jul 3, 2018
Rollup of 13 pull requests Successful merges: - #51548 (Initialize LLVM's AMDGPU target machine, if available.) - #51809 (Add read_exact_at and write_all_at methods to FileExt on unix) - #51914 (add outlives annotations to `BTreeMap`) - #51958 (Show known meta items in unknown meta items error) - #51973 (Make Stdio handle UnwindSafe) - #51977 (bootstrap: tests should use rustc from config.toml) - #51978 (Do not suggest changes to str literal if it isn't one) - #51979 (Get rid of `TyImplTraitExistential`) - #51980 (Emit column info in debuginfo for non msvc like targets) - #51982 (incr.comp.: Take names of children into account when computing the ICH of a module's HIR.) - #51997 (add entry for cargo-metadata feature to RELEASES) - #52004 (toolstate: Fixed detection of changed submodule, and other fixes.) - #52006 ( Change --keep-stage to apply more often) Failed merges: r? @ghost
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42921 everywhere except MSVC. This mimics clang behaviour.