Skip to content

Make verbose --version show if parallel queries are supported. #52052

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Conversation

michaelwoerister
Copy link
Member

This should not break anything, right?

r? @Mark-Simulacrum
cc @rust-lang/release @Zoxc

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 4, 2018
@Mark-Simulacrum
Copy link
Member

This may affect cargo's parsing - I'll try to test locally...

@Mark-Simulacrum
Copy link
Member

Yes, this should be fine, it'll result in recompiles for anyone who switches to such a compiler but that's mostly acceptable.

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 4, 2018

📌 Commit 4b6635e has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 4, 2018
@michaelwoerister
Copy link
Member Author

Thanks for checking!

@michaelwoerister
Copy link
Member Author

@bors rollup

kennytm added a commit to kennytm/rust that referenced this pull request Jul 6, 2018
…ies, r=Mark-Simulacrum

Make verbose --version show if parallel queries are supported.

This should not break anything, right?

r? @Mark-Simulacrum
cc @rust-lang/release @Zoxc
bors added a commit that referenced this pull request Jul 6, 2018
Rollup of 14 pull requests

Successful merges:

 - #51619 (rust: add initial changes to support powerpc64le musl)
 - #51793 (Fix variant background color on hover in search results)
 - #52005 (Update LLVM to bring in a wasm codegen fix)
 - #52016 (Deduplicate error reports for statics)
 - #52019 ([cross-lang-lto] Allow the linker to choose the LTO-plugin (which is useful when using LLD))
 - #52030 (Any docs preposition change)
 - #52031 (Strenghten synchronization in `Arc::is_unique`)
 - #52033 ([Gardening] Update outdated comments: ByVal -> Scalar)
 - #52052 (Make verbose --version show if parallel queries are supported.)
 - #52055 (Include VS 2017 in error message.)
 - #52063 (Add a link to the rustc docs)
 - #52073 (Add a punch card to weird expressions test)
 - #52080 (Improve dependency deduplication diagnostics)
 - #51953 (enable Atomic*.{load,store} for ARMv6-M / MSP430)

Failed merges:
@kennytm
Copy link
Member

kennytm commented Jul 6, 2018

@bors rollup-

Turns out this does break something 🤔, see #52088 (comment).

@michaelwoerister
Copy link
Member Author

Pity. OK, I'll move it to a -Z flag.

@pietroalbini
Copy link
Member

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 7, 2018
@TimNN
Copy link
Contributor

TimNN commented Jul 17, 2018

Ping from triage, @michaelwoerister ! We haven't heard from you about this PR in a while.

@pietroalbini
Copy link
Member

Thank you for this PR @michaelwoerister! Unfortunately we haven't heard from you on this in a while, so I'm closing the PR to keep things tidy. Don't worry though, if you'll have time again in the future please reopen this PR, we'll be happy to review it again!

@pietroalbini pietroalbini added S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 30, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants