Add "self" intra-link support #52368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
src/librustdoc/core.rs
Outdated
| @@ -82,7 +82,8 @@ pub struct DocContext<'a, 'tcx: 'a, 'rcx: 'a> { | |||
| pub fake_def_ids: RefCell<FxHashMap<CrateNum, DefId>>, | |||
| pub all_fake_def_ids: RefCell<FxHashSet<DefId>>, | |||
| /// Maps (type_id, trait_id) -> auto trait impl | |||
| pub generated_synthetics: RefCell<FxHashSet<(DefId, DefId)>> | |||
| pub generated_synthetics: RefCell<FxHashSet<(DefId, DefId)>>, | |||
| pub current_item_id: RefCell<Option<Name>>, | |||
There was a problem hiding this comment.
We tried so hard to keep from having to use a current_item field in the DocContext, but it looks like this is the easiest way, short of not processing attributes through the Clean trait.
Could you make this say current_item_name, since it's not really an ID we're putting here?
There was a problem hiding this comment.
Oh true, I changed meanwhile and forgot to update the variable's name.
stokhos
added
S-waiting-on-author
GuillaumeGomez
force-pushed
the
intra_doc_link_resolution_failure-documented
branch
from
259119b to
88f2643
Compare
|
Updated. |
|
@bors: r=QuietMisdreavus |
|
📌 Commit 88f2643 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jul 22, 2018
…re-documented, r=QuietMisdreavus Add "self" intra-link support Fixes #49583. r? @QuietMisdreavus
|
☀️ Test successful - status-appveyor, status-travis |
27 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49583.
r? @QuietMisdreavus