Skip to content

Revert #52212 (revert set opt-level = 3) #52379

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jul 14, 2018
Merged

Conversation

kennytm
Copy link
Member

@kennytm kennytm commented Jul 14, 2018

Setting -O3 causes LLVM to spuriously segfault at least on Linux. This PR reverts to -O2.

cc #52378

…ton"

This reverts commit 1731f0a, reversing
changes made to 0a8275f.
@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 14, 2018
@kennytm kennytm changed the title Revert #52212 (set opt-level = 3) Revert #52212 (revert set opt-level = 3) Jul 14, 2018
@hanna-kruppe
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 14, 2018

📌 Commit d332fc3 has been approved by rkruppe

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 14, 2018
@kennytm
Copy link
Member Author

kennytm commented Jul 14, 2018

@bors p=1

@bors
Copy link
Collaborator

bors commented Jul 14, 2018

⌛ Testing commit d332fc3 with merge cbcd81a...

bors added a commit that referenced this pull request Jul 14, 2018
Revert #52212 (revert set opt-level = 3)

Setting -O3 causes LLVM to spuriously segfault at least on Linux. This PR reverts to -O2.

cc #52378
@bors
Copy link
Collaborator

bors commented Jul 14, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: rkruppe
Pushing cbcd81a to master...

@bors bors merged commit d332fc3 into rust-lang:master Jul 14, 2018
@kennytm kennytm deleted the revert-o3 branch July 14, 2018 20:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants