Categorize queries for later self-profiling #52476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Change the define_queries! macro per feedback on rust-lang#51657. Big thanks to @mark-i-m for the help getting the macro changes correct!
wesleywiser
force-pushed
the
categorize_queries
branch
from
061e1e3 to
0223ef9
Compare
|
@bors r+ |
|
📌 Commit 0223ef9 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jul 20, 2018
Categorize queries for later self-profiling Change the define_queries! macro per feedback on #51657. Big thanks to @mark-i-m for the help getting the macro changes correct! I'm pulling this commit out of the other PR because it's hard to keep up-to-date as queries are added or changed. r? @nikomatsakis
|
☀️ Test successful - status-appveyor, status-travis |
This was referenced Jul 20, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the define_queries! macro per feedback on #51657.
Big thanks to @mark-i-m for the help getting the macro changes correct!
I'm pulling this commit out of the other PR because it's hard to keep up-to-date as queries are added or changed.
r? @nikomatsakis