-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Remove duplicate E0396 tests #52527
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Remove duplicate E0396 tests #52527
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
It appears that the original test case might need to be adjusted.
|
r? @oli-obk |
src/test/run-pass/const-block.rs
Outdated
// const X: *const isize = 0xdeadbeef as *const isize; | ||
// &*X | ||
// }; | ||
static BLOCK_UNSAFE_SAFE_PTR: &'static isize = unsafe { &*(0xdeadbeef as *const isize) }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
O_o this compiles?! This should not compile
Oh I should have read the rest of the PR... yea these should already have test cases in |
@oli-obk indeed, there already is a test for this; I updated the commit and the PR message. |
@bors r+ rollup |
📌 Commit 576cfc5 has been approved by |
Remove duplicate E0396 tests Resolves FIXME rust-lang#13973 (erroneously marked as rust-lang#13972). A test for E0396 already exists in `test/ui/const-deref-ptr.rs`.
Remove duplicate E0396 tests Resolves FIXME rust-lang#13973 (erroneously marked as rust-lang#13972). A test for E0396 already exists in `test/ui/const-deref-ptr.rs`.
Remove duplicate E0396 tests Resolves FIXME rust-lang#13973 (erroneously marked as rust-lang#13972). A test for E0396 already exists in `test/ui/const-deref-ptr.rs`.
Rollup of 7 pull requests Successful merges: - #52502 (fix unsafety: don't call ptr_rotate for ZST) - #52505 (rustc: Remove a workaround in ThinLTO fixed upstream) - #52526 (Enable run-pass/sepcomp-lib-lto.rs on Android) - #52527 (Remove duplicate E0396 tests) - #52539 (rustc: Fix two custom attributes with custom derive) - #52540 (Fix docker/run.sh script when run locally) - #52573 (Cleanups) Failed merges: r? @ghost
Resolves FIXME #13973 (erroneously marked as #13972). A test for E0396 already exists in
test/ui/const-deref-ptr.rs
.