Impl Executor for Box<E: Executor> #52674

tinaun · 2018-07-24T19:33:50Z

removes the need for the compatibility lib between futures 0.1 and 0.3 to use a wrapper type to implement Executor for Box

rust-highfive · 2018-07-24T19:33:53Z

r? @bluss

(rust_highfive has picked a reviewer for you, use r? to override)

rust-highfive · 2018-07-24T19:39:25Z

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.


[00:03:59] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:03:59] tidy error: /checkout/src/liballoc/boxed.rs:980: trailing whitespace
[00:03:59] tidy error: /checkout/src/liballoc/boxed.rs:982: trailing whitespace
[00:03:59] tidy error: /checkout/src/liballoc/boxed.rs:984: trailing whitespace
[00:04:01] some tidy checks failed
[00:04:01] 
[00:04:01] 
[00:04:01] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:04:01] 
[00:04:01] 
[00:04:01] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:04:01] Build completed unsuccessfully in 0:00:50
[00:04:01] Build completed unsuccessfully in 0:00:50
[00:04:01] Makefile:79: recipe for target 'tidy' failed
[00:04:01] make: *** [tidy] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:0535824c
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:029e1b77:start=1532461160111258511,finish=1532461160118949665,duration=7691154
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:1ebaaddd
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:004a3974
travis_time:start:004a3974
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:009f3eb0
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2018-07-24T20:43:34Z

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:04:41]    Compiling std_unicode v0.0.0 (file:///checkout/src/libstd_unicode)
[00:04:41] error[E0412]: cannot find type `E` in this scope
[00:04:41]    --> liballoc/boxed.rs:976:23
[00:04:41]     |
[00:04:41] 976 | impl Executor for Box<E>
[00:04:41]     |                       ^ did you mean `Eq`?
[00:04:41] error[E0412]: cannot find type `E` in this scope
[00:04:41]    --> liballoc/boxed.rs:977:11
[00:04:41]     |
[00:04:41]     |
[00:04:41] 977 |     where E: Executor
[00:04:41]     |           ^ did you mean `Eq`?
[00:04:41] 
[00:04:42] error[E0307]: invalid `self` type: &mut boxed::Box<[type error]>
[00:04:42]    --> liballoc/boxed.rs:979:18
[00:04:42]     |
[00:04:42] 979 |     fn spawn_obj(&mut self, task: FutureObj<'static, ()>) -> Result<(), SpawnObjError> {
[00:04:42]     |
[00:04:42]     |
[00:04:42]     = note: type must be `boxed::Box<[type error]>` or a type that dereferences to it
[00:04:42]     = help: consider changing to `self`, `&self`, `&mut self`, or `self: Box<Self>`
[00:04:42] 
[00:04:42] error[E0307]: invalid `self` type: &boxed::Box<[type error]>
[00:04:42]    --> liballoc/boxed.rs:983:15
[00:04:42]     |
[00:04:42] 983 |     fn status(&self) -> Result<(), SpawnErrorKind> {
[00:04:42]     |
[00:04:42]     |
[00:04:42]     = note: type must be `boxed::Box<[type error]>` or a type that dereferences to it
[00:04:42]     = help: consider changing to `self`, `&self`, `&mut self`, or `self: Box<Self>`
[00:04:42]    Compiling alloc_system v0.0.0 (file:///checkout/src/liballoc_system)
[00:04:42]    Compiling panic_abort v0.0.0 (file:///checkout/src/libpanic_abort)
[00:04:42] error: aborting due to 4 previous errors
[00:04:42] 
[00:04:42] 
[00:04:42] Some errors occurred: E0307, E0412.
[00:04:42] For more information about an error, try `rustc --explain E0307`.
[00:04:42] error: Could not compile `alloc`.
[00:04:42] 
[00:04:42] Caused by:
[00:04:42]   process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustc --crate-name alloc liballoc/lib.rs --color always --error-format json --crate-type lib --emit=dep-info,link -C opt-level=2 -C metadata=0fa369be6843d38b -C extra-filename=-0fa369be6843d38b --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/stage0-std/x86_64-unknown-linux-gnu/release/deps --target x86_64-unknown-linux-gnu -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-std/x86_64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-std/release/deps --extern compiler_builtins=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-std/x86_64-unknown-linux-gnu/release/deps/libcompiler_builtins-b64848753b7b1fae.rlib --extern core=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-std/x86_64-unknown-linux-gnu/release/deps/libcore-13801a3823f081b4.rlib -L native=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-std/x86_64-unknown-linux-gnu/release/build/compiler_builtins-70f4afff694b17e5/out` (exit code: 101)
[00:04:42] error: build failed
[00:04:42] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" "panic-unwind jemalloc backtrace" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "--message-format" "json"
[00:04:42] expected success, got: exit code: 101
[00:04:42] expected success, got: exit code: 101
[00:04:42] thread 'main' panicked at 'cargo must succeed', bootstrap/compile.rs:1119:9
[00:04:42] travis_fold:end:stage0-std

[00:04:42] travis_time:end:stage0-std:start=1532464978603267562,finish=1532465010306170390,duration=31702902828


[00:04:42] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap build
[00:04:42] Build completed unsuccessfully in 0:00:32
[00:04:42] Makefile:28: recipe for target 'all' failed
[00:04:42] make: *** [all] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:01f876c8
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:084c7720:start=1532465011016343856,finish=1532465011030176302,duration=13832446
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:13b7616a
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:05aa0912
travis_time:start:05aa0912
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:1153d08e
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

cramertj · 2018-07-25T18:18:23Z

@bors r+ rollup

bors · 2018-07-25T18:18:24Z

📌 Commit 75d2226 has been approved by cramertj

bors · 2018-07-25T18:18:24Z

🌲 The tree is currently closed for pull requests below priority 99, this pull request will be tested once the tree is reopened

Impl Executor for Box<E: Executor> removes the need for the compatibility lib between futures 0.1 and 0.3 to use a wrapper type to implement Executor for Box<Executor>

@ghost

Rollup of 16 pull requests Successful merges: - #52558 (Add tests for ICEs which no longer repro) - #52610 (Clarify what a task is) - #52617 (Don't match on region kinds when reporting NLL errors) - #52635 (Fix #[linkage] propagation though generic functions) - #52647 (Suggest to take and ignore args while closure args count mismatching) - #52649 (Point spans to inner elements of format strings) - #52654 (Format linker args in a way that works for gcc and ld) - #52667 (update the stdsimd submodule) - #52674 (Impl Executor for Box<E: Executor>) - #52690 (ARM: expose `rclass` and `dsp` target features) - #52692 (Improve readability in a few sorts) - #52695 (Hide some lints which are not quite right the way they are reported to the user) - #52718 (State default capacity for BufReader/BufWriter) - #52721 (std::ops::Try impl for std::task::Poll) - #52723 (rustc: Register crates under their real names) - #52734 (sparc ABI issue - structure returning from function is returned in 64bit registers (with tests)) Failed merges: - #52678 ([NLL] Use better spans in some errors) r? @ghost

rust-highfive assigned bluss Jul 24, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 24, 2018

tinaun force-pushed the patch-2 branch from bd5abac to 0385131 Compare July 24, 2018 20:37

tinaun force-pushed the patch-2 branch from 0385131 to ebe116c Compare July 24, 2018 20:57

Impl Executor for Box<E: Executor>

75d2226

tinaun force-pushed the patch-2 branch from ebe116c to 75d2226 Compare July 24, 2018 21:13

tinaun mentioned this pull request Jul 25, 2018

Compat implementation rust-lang/futures-rs#1119

Merged

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 25, 2018

Mark-Simulacrum mentioned this pull request Jul 26, 2018

Rollup of 16 pull requests #52735

Merged

bors merged commit 75d2226 into rust-lang:master Jul 26, 2018

tinaun deleted the patch-2 branch April 23, 2020 22:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Impl Executor for Box<E: Executor> #52674

Impl Executor for Box<E: Executor> #52674

tinaun commented Jul 24, 2018

rust-highfive commented Jul 24, 2018

rust-highfive commented Jul 24, 2018

rust-highfive commented Jul 24, 2018

cramertj commented Jul 25, 2018

bors commented Jul 25, 2018

bors commented Jul 25, 2018

Impl Executor for Box<E: Executor> #52674

Impl Executor for Box<E: Executor> #52674

Conversation

tinaun commented Jul 24, 2018

rust-highfive commented Jul 24, 2018

rust-highfive commented Jul 24, 2018

rust-highfive commented Jul 24, 2018

cramertj commented Jul 25, 2018

bors commented Jul 25, 2018

bors commented Jul 25, 2018