Misc cleanups #52764

sinkuu · 2018-07-27T08:40:01Z

No description provided.

rust-highfive · 2018-07-27T08:40:13Z

(rust_highfive has picked a reviewer for you, use r? to override)

rust-highfive · 2018-07-27T09:15:55Z

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

18556 ./obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu
18552 ./obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release
18200 ./obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps
14964 ./src/test/run-pass
travis_time:end:09640978:start=1532682952147371431,finish=1532682952387445437,durat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:08dfc5ac
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

ljedrz · 2018-07-27T09:27:39Z

src/librustc_errors/emitter.rs

-        if line.annotations.is_empty() || line.annotations.iter()
-            .filter(|a| !a.is_line()).collect::<Vec<_>>().len() == 0
-        {
+        if line.annotations.iter().all(|a| a.is_line()) {


Shouldn't this be line.annotations.is_empty() || line.annotations.iter().all(|a| a.is_line())?

Iterator::all returns true for an empty iterator.

Ah, ok; nice 👌.

ljedrz · 2018-07-27T12:10:05Z

@sinkuu I doubt that your changes broke asan, so you might want to close and reopen this PR to trigger a re-test.

sinkuu · 2018-07-27T12:46:54Z

There was actually an error. The bot quoted irrevant parts of the log.

rust-highfive · 2018-07-27T13:43:31Z

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:58:00] travis_fold:start:test_stage1-core
travis_time:start:test_stage1-core
Testing core stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[00:58:00]    Compiling core v0.0.0 (file:///checkout/src/libcore)
[00:58:03] error: unused import: `std::iter`
[00:58:03]   --> libcore/../libcore/tests/num/dec2flt/parse.rs:11:5
[00:58:03] 11 | use std::iter;
[00:58:03]    |     ^^^^^^^^^
[00:58:03]    |
[00:58:03]    = note: `-D unused-imports` implied by `-D warnings`
---
[00:58:14] 
[00:58:14] To learn more, run the command again with --verbose.
[00:58:14] 
[00:58:14] 
[00:58:14] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" "panic-unwind jemalloc backtrace" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "-p" "core" "--" "--quiet"
[00:58:14] 
[00:58:14] 
[00:58:14] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[00:58:14] Build completed unsuccessfully in 0:16:54
[00:58:14] Build completed unsuccessfully in 0:16:54
[00:58:14] make: *** [check] Error 1
[00:58:14] Makefile:58: recipe for target 'check' failed

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:0760c78a
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:06cee71c:start=1532699005827470738,finish=1532699005836909340,duration=9438602
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0c41f6be
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0005f07c
travis_time:start:0005f07c
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:0151841a
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

nikomatsakis · 2018-07-28T04:54:02Z

@bors r+

bors · 2018-07-28T04:54:03Z

📌 Commit e995a91 has been approved by nikomatsakis

bors · 2018-07-29T06:32:31Z

⌛ Testing commit e995a91 with merge a5c2d0f...

Misc cleanups

bors · 2018-07-29T08:26:31Z

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing a5c2d0f to master...

rust-highfive assigned nikomatsakis Jul 27, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 27, 2018

ljedrz reviewed Jul 27, 2018

View reviewed changes

sinkuu force-pushed the cleanup branch from eae2bf4 to fde2198 Compare July 27, 2018 12:42

sinkuu added 5 commits July 27, 2018 23:26

Use str::repeat

3525368

Remove unnecessary .collect()

8296699

Unnecessary to_string

4c1cb75

Simplify

1bc49a9

Better Option handling

e995a91

sinkuu force-pushed the cleanup branch from fde2198 to e995a91 Compare July 27, 2018 14:27

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 28, 2018

bors added a commit that referenced this pull request Jul 29, 2018

Auto merge of #52764 - sinkuu:cleanup, r=nikomatsakis

a5c2d0f

Misc cleanups

bors merged commit e995a91 into rust-lang:master Jul 29, 2018

pnkfelix mentioned this pull request Oct 9, 2018

error: internal compiler error: Accessing (*_310) with the kind Write(Move) shouldn't be possible #54597

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Misc cleanups #52764

Misc cleanups #52764

sinkuu commented Jul 27, 2018

rust-highfive commented Jul 27, 2018

rust-highfive commented Jul 27, 2018

ljedrz Jul 27, 2018

sinkuu Jul 27, 2018

ljedrz Jul 27, 2018

ljedrz commented Jul 27, 2018

sinkuu commented Jul 27, 2018

rust-highfive commented Jul 27, 2018

nikomatsakis commented Jul 28, 2018

bors commented Jul 28, 2018

bors commented Jul 29, 2018

bors commented Jul 29, 2018

Misc cleanups #52764

Misc cleanups #52764

Conversation

sinkuu commented Jul 27, 2018

rust-highfive commented Jul 27, 2018

rust-highfive commented Jul 27, 2018

ljedrz Jul 27, 2018

Choose a reason for hiding this comment

sinkuu Jul 27, 2018

Choose a reason for hiding this comment

ljedrz Jul 27, 2018

Choose a reason for hiding this comment

ljedrz commented Jul 27, 2018

sinkuu commented Jul 27, 2018

rust-highfive commented Jul 27, 2018

nikomatsakis commented Jul 28, 2018

bors commented Jul 28, 2018

bors commented Jul 29, 2018

bors commented Jul 29, 2018