Skip to content

Add aarch64-unknown-netbsd target #53165

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged

Conversation

jakllsch
Copy link
Contributor

@jakllsch jakllsch commented Aug 7, 2018

Depends on #53116.

@rust-highfive
Copy link
Contributor

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 7, 2018
@estebank
Copy link
Contributor

estebank commented Aug 7, 2018

r=me once #53116 has been merged

@kennytm kennytm added S-blocked Status: Blocked on something else such as an RFC or other implementation work. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Aug 9, 2018
@kennytm
Copy link
Member

kennytm commented Aug 9, 2018

#53116 has been merged. Do you expect a rebase?

@estebank
Copy link
Contributor

estebank commented Aug 9, 2018

@bors r+ rollup

@kennytm 👍

@bors
Copy link
Collaborator

bors commented Aug 9, 2018

📌 Commit 1dd53f7 has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 9, 2018
@jakllsch
Copy link
Contributor Author

I can rebase this if necessary.

@jakllsch
Copy link
Contributor Author

I haven't been able to test this yet. If I could get a newer libc crate to build against first that'd be awesome.

@kennytm
Copy link
Member

kennytm commented Aug 11, 2018

@bors r=estebank

@bors
Copy link
Collaborator

bors commented Aug 11, 2018

📌 Commit 538d1ba has been approved by estebank

kennytm added a commit to kennytm/rust that referenced this pull request Aug 11, 2018
…8156-f717d36f6bbe, r=estebank

 Add aarch64-unknown-netbsd target

Depends on rust-lang#53116.
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 12, 2018
…8156-f717d36f6bbe, r=estebank

 Add aarch64-unknown-netbsd target

Depends on rust-lang#53116.
bors added a commit that referenced this pull request Aug 12, 2018
Rollup of 15 pull requests

Successful merges:

 - #52955 (Update compiler test documentation)
 - #53019 (Don't collect() when size_hint is useless)
 - #53025 (Consider changing assert! to debug_assert! when it calls visit_with)
 - #53059 (Remove explicit returns where unnecessary)
 - #53165 ( Add aarch64-unknown-netbsd target)
 - #53210 (Deny future duplication of rustc-ap-syntax)
 - #53223 (A few cleanups for rustc_data_structures)
 - #53230 ([nll] enable feature(nll) on various crates for bootstrap: part 4)
 - #53231 (Add let keyword doc)
 - #53240 (Add individual documentation for <integer>`.swap_bytes`/.`reverse_bits`)
 - #53253 (Remove unwanted console log)
 - #53264 (Show that Command can be reused and remodified)
 - #53267 (Fix styles)
 - #53273 (Add links to std::char::REPLACEMENT_CHARACTER from docs.)
 - #53283 (wherein we suggest float for integer literals where a float was expected)

Failed merges:

r? @ghost
@bors bors merged commit 538d1ba into rust-lang:master Aug 13, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants