avoid computing liveness when possible #53168
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
In particular, we skip computing liveness for a variable X if all the regions in its type are known to outlive free regions.
nikomatsakis
force-pushed
the
nll-escaping-into-return-take-2
branch
from
e114ee5 to
3b7989d
Compare
|
@bors try Local experiments suggest this will be a big perf win, just as before. The diagnostics do degrade, I think, slightly. I think we could probably fix that. |
|
⌛ Trying commit 3b7989d with merge aea424935d9666ab3a7efc69c7e88452e460479c... |
nikomatsakis
added
S-waiting-on-perf
|
☀️ Test successful - status-travis |
|
@rust-timer build aea424935d9666ab3a7efc69c7e88452e460479c |
|
Success: Queued aea424935d9666ab3a7efc69c7e88452e460479c with parent ccb550f, comparison URL. |
kennytm
added
S-waiting-on-review
|
Perf is ready. The numbers look pretty good. |
|
I think I will close this in favor of #53177, which builds on it but does more. |
bors
added a commit
that referenced
this pull request
Aug 10, 2018
…g-values, r=pnkfelix optimize redundant borrows and escaping paths in NLL This builds on #53168 and adds a commit that addresses #53176 -- or at least I think it does. I marked this as WIP because I want to see the test results (and measure the performance). I also want to double check we're not adding in any unsoundness here.
bors
added a commit
that referenced
this pull request
Aug 10, 2018
…g-values, r=pnkfelix optimize redundant borrows and escaping paths in NLL This builds on #53168 and adds a commit that addresses #53176 -- or at least I think it does. I marked this as WIP because I want to see the test results (and measure the performance). I also want to double check we're not adding in any unsoundness here.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second stab at #52713. This version avoids computing liveness for variables whose types contain only regions that are known to extend free regions (for any reason, maybe not just because they are returned).
Fixes #52713
r? @pnkfelix
cc @lqd