Skip to content

syntax_ext: remove leftover span_err_if_not_stage0 macro. #53412

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Aug 16, 2018

Conversation

eddyb
Copy link
Member

@eddyb eddyb commented Aug 15, 2018

I believe this is the right fix for #53380, although I'm not sure what happened.
My guess is this copy of the macro was accidentally missed when others were removed?

cc @matthewjasper @varkor (please do not put this in a rollup, in case it fails)

@rust-highfive
Copy link
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 15, 2018
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Collaborator

bors commented Aug 15, 2018

📌 Commit 494889e has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 15, 2018
@RalfJung
Copy link
Member

RalfJung commented Aug 16, 2018

I think there are other tests that could have their // ignore-stage1 removed. Let me see if I can somehow grep for that...

EDIT: Hm, there are not even that many. I thought I had seem some more being added when this macro came in but seems like I was wrong...

@RalfJung
Copy link
Member

RalfJung commented Aug 16, 2018

Ah no there is at least src/test/ui/E0661.rs.

EDIT: Actually, all these E* tests seem to be affected.

@RalfJung
Copy link
Member

I removed some more // ignore-stage1, in fact there are none left now among the ui tests.

@bors r=alexcrichton

@bors
Copy link
Collaborator

bors commented Aug 16, 2018

📌 Commit e7b65bd has been approved by alexcrichton

kennytm added a commit to kennytm/rust that referenced this pull request Aug 16, 2018
 syntax_ext: remove leftover span_err_if_not_stage0 macro.

I believe this is the right fix for rust-lang#53380, although I'm not sure what happened.
My guess is this copy of the macro was accidentally missed when others were removed?

cc @matthewjasper @varkor (please do not put this in a rollup, in case it fails)
bors added a commit that referenced this pull request Aug 16, 2018
Rollup of 10 pull requests

Successful merges:

 - #52946 (Documented impl From on line 367 of libserialize/json.rs)
 - #53234 (Remove Travis shutdown debug scripts, and remove CI-specific DNS settings)
 - #53313 (Two small improvements)
 - #53360 (Addressed #51602)
 - #53364 (Warn if the user tries to use GATs)
 - #53373 (Tweak unclosed delimiter parser error)
 - #53377 (std: Use target_pointer_width for BACKTRACE_ELF_SIZE)
 - #53395 (Use #[non_exhaustive] on internal enums)
 - #53399 (Tidy: ignore non-Markdown files when linting for the Unstable Book)
 - #53412 (syntax_ext: remove leftover span_err_if_not_stage0 macro.)
@bors bors merged commit e7b65bd into rust-lang:master Aug 16, 2018
@eddyb eddyb deleted the stage-who branch August 17, 2018 00:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants