Add Error::source method per RFC 2504. #53533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
withoutboats
added
the
T-libs-api
|
@rfcbot fcp merge Tracking issue #53487 RFC rust-lang/rfcs#2504 |
|
Team member @withoutboats has proposed to merge this. The next step is review by the rest of the tagged teams: No concerns currently listed. Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
rfcbot
added
proposed-final-comment-period
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
🔔 This is now entering its final comment period, as per the review above. 🔔 |
rfcbot
added
final-comment-period
|
Code-wise change looks fine to me. |
Mark-Simulacrum
added
S-waiting-on-team
|
@bors delegate+ |
|
✌️ @withoutboats can now approve this pull request |
rfcbot
added
the
finished-final-comment-period
|
The final comment period, with a disposition to merge, as per the review above, is now complete. |
rfcbot
removed
the
final-comment-period
|
@bors r+ |
|
📌 Commit e2e4f57 has been approved by |
bors
removed
the
S-waiting-on-team
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit e2e4f57 with merge 328565efd875a4949bdcfc2d4ecc55a97d796648... |
|
💔 Test failed - status-travis |
bors
added
S-waiting-on-review
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
@bors retry The linker is killed with SIGILL. The error doesn't seem relevant at all. |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Sep 1, 2018
Add Error::source method per RFC 2504. This implements part of RFC 2504. * Adds `Error::source`, a replacement for `Error::cause` with the "right" signature, which will be instantly stable. * Deprecates `Error::cause` in 1.33 (this choice was based on the precedent in #52994, which we haven't finalized). * Redefines `Error::cause` to delegate to `Error::source` (the delegation can only go in this direction, not the other). @rfcbot fcp merge
|
☀️ Test successful - status-appveyor, status-travis |
9 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements part of RFC 2504.
Error::source, a replacement forError::causewith the "right" signature, which will be instantly stable.Error::causein 1.33 (this choice was based on the precedent in Add trim_start, trim_end etc.; deprecate trim_left, trim_right, etc. in future #52994, which we haven't finalized).Error::causeto delegate toError::source(the delegation can only go in this direction, not the other).@rfcbot fcp merge