Skip to content

Update RELEASES.md to include clippy-preview #53594

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Aug 24, 2018
Merged

Update RELEASES.md to include clippy-preview #53594

merged 2 commits into from
Aug 24, 2018

Conversation

XAMPPRocky
Copy link
Member

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 22, 2018
RELEASES.md Outdated
@@ -39,6 +39,8 @@ Misc
will demote `deny` and `forbid` lints to `warn`.
- [`rustc` and `rustdoc` will now have the exit code of `1` if compilation
fails, and `101` if there is a panic.][52197]
- [Added a preview of clippy has been made available through rustup][51122]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was supposed start with "A preview of Clippy [...]"

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 22, 2018

📌 Commit 200c6d9 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 22, 2018
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Aug 22, 2018
@kennytm kennytm added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Aug 23, 2018
@kennytm
Copy link
Member

kennytm commented Aug 23, 2018

@bors rollup

Beta-nominating as part of 1.29's release note.

kennytm added a commit to kennytm/rust that referenced this pull request Aug 24, 2018
bors added a commit that referenced this pull request Aug 24, 2018
Rollup of 16 pull requests

Successful merges:

 - #53311 (Window Mutex: Document that we properly initialize the SRWLock)
 - #53503 (Discourage overuse of mem::forget)
 - #53545 (Fix #50865: ICE on impl-trait returning functions reaching private items)
 - #53559 (add macro check for lint)
 - #53562 (Lament the invincibility of the Turbofish)
 - #53563 (use String::new() instead of String::from(""), "".to_string(), "".to_owned() or "".into())
 - #53592 (docs: minor stylistic changes to str/string docs)
 - #53594 (Update RELEASES.md to include clippy-preview)
 - #53600 (Fix a grammatical mistake in "expected generic arguments" errors)
 - #53614 (update nomicon and book)
 - #53617 (tidy: Stop requiring a license header)
 - #53618 (Add missing fmt examples)
 - #53636 (Prefer `.nth(n)` over `.skip(n).next()`.)
 - #53644 (Use SmallVec for SmallCStr)
 - #53664 (Remove unnecessary closure in rustc_mir/build/mod.rs)
 - #53666 (Added rustc_codegen_llvm to compiler documentation.)
@bors bors merged commit 200c6d9 into master Aug 24, 2018
@pietroalbini pietroalbini added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Aug 25, 2018
@pietroalbini pietroalbini removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Aug 25, 2018
bors added a commit that referenced this pull request Aug 25, 2018
[beta] Rollup backports

Merged and approved:

* #53030: Updated RELEASES.md for 1.29.0
* #53594: Update RELEASES.md to include clippy-preview
* #53045: Fix NLL migration mode so that reports region errors when necessary.
* #53163: Remove an overly pedantic and wrong assertion

r? @ghost
@bjorn3
Copy link
Member

bjorn3 commented Sep 11, 2018

@Aaronepower why did you create this branch on rust-lang/rust instead of your personal fork? (https://github.com/rust-lang/rust/tree/Aaronepower-patch-1)

@XAMPPRocky XAMPPRocky deleted the Aaronepower-patch-1 branch September 11, 2018 16:47
@XAMPPRocky
Copy link
Member Author

XAMPPRocky commented Sep 11, 2018

@bjorn3 Whoops, that was not intentional I created the pull request through GitHub's UI which before I was a team member would put it on my personal fork, apparently that behaviour changed I've deleted the branch now.

@bjorn3
Copy link
Member

bjorn3 commented Sep 11, 2018

:) noticed it when I pulled

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants