Rollup of 19 pull requests #53775
Closed
Rollup of 19 pull requests #53775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a ~1% win on `keccak` and `inflate`.
This reduces the execution time for `ucd-check` by 25%.
This commit generalizes the existing `async_idents` lint to easily encompass other identifiers that will be keywords in future editions. The new lint is called `keyword_idents` and the old `async_idents` lint is registered as renamed to this new lint. As a proof of concept the `try` keyword was added to this list as it looks to be listed as a keyword in the 2018 edition only. The `await` keyword was not added as it's not listed as a keyword yet. Closes rust-lang#53077
This commit updates the `unused_extern_crates` lint to make automatic suggestions about removing `extern crate` annotations in the 2018 edition. This ended up being a little easier than originally though due to what's likely been fixed issues in the resolver! Closes rust-lang#52829
This typo was introduced in rust-lang#47334. A couple tests bitrotted as a result, so we fix those too, and move them to a more sensible place.
…q-example, r=QuietMisdreavus Add another PartialEq example r? @steveklabnik
…omez Add example for Cow Add one more example that shows how to keep `Cow` in a struct. Link to playground: https://play.rust-lang.org/?gist=a9256bdd034b44bc3cdd0044bbcdbb7c&version=stable&mode=debug&edition=2015 Users ask this question in [ruRust](https://gitter.im/ruRust/general) chat time to time and it is not obvious to add `ToOwned<Owned=Target>` to requirements of generic params.
…, r=pnkfelix remove `let x = baz` which was obscuring the real error fixes rust-lang#51172
document effect of join on memory ordering Fixes rust-lang#45467
Use FxHash{Map,Set} instead of the default Hash{Map,Set} everywhere in rustc.
Most of the compiler uses the `Fx` hasher but some places ended up with the default one.
… r=varkor Force-inline `shallow_resolve` at its hottest call site. It's a ~1% win on `keccak` and `inflate`.
cleanup: Add main functions to some UI tests
set applicability Update a few more calls as described in rust-lang#50723 r? @estebank
rustc: Suggest removing `extern crate` in 2018 This commit updates the `unused_extern_crates` lint to make automatic suggestions about removing `extern crate` annotations in the 2018 edition. This ended up being a little easier than originally though due to what's likely been fixed issues in the resolver! Closes rust-lang#52829
Generalize `async_idents` to all new keywords This commit generalizes the existing `async_idents` lint to easily encompass other identifiers that will be keywords in future editions. The new lint is called `keyword_idents` and the old `async_idents` lint is registered as renamed to this new lint. As a proof of concept the `try` keyword was added to this list as it looks to be listed as a keyword in the 2018 edition only. The `await` keyword was not added as it's not listed as a keyword yet. Closes rust-lang#53077
…o_vis_matcher, r=cramertj Fix stabilisation version for macro_vis_matcher. r? @cramertj
…, r=nikomatsakis Do not suggest dereferencing in macro Fix rust-lang#52783.
save-analysis: Differentiate foreign functions and statics.
…ikomatsakis Avoid calling `unroll_place()` in a common case. This reduces the execution time for `ucd-check` by 25%. r? @nikomatsakis
add llvm-readobj to llvm-tools-preview Similar to readelf but supports more object formats (it seems). Particularly useful to inspect in detail sections (e.g. their flags) and symbols (e.g. their types). r? @alexcrichton cc @dvc94ch
fix a typo: taget_env -> target_env This typo was introduced in rust-lang#47334. A couple tests bitrotted as a result, so we fix those too, and move them to a more sensible place. Is there some lint we could turn on that would've caught this? It's a drag that cfg typos can silently pass through the compiler.
…etMisdreavus Rustdoc fixes Fixes rustdoc not scrolling to given lines and invalid unstable display: <img width="1440" alt="screen shot 2018-08-27 at 23 28 47" src="https://user-images.githubusercontent.com/3050060/44687252-06535e80-aa51-11e8-8512-d7d34d1cb963.png"> r? @QuietMisdreavus
expand keep-stage --help text
move file-extension based .gitignore down to src/ Currently, it for example ignores `*.rlib` files in the repository root -- which I think is wrong; I sometimes get these files when I call rustc directly and I do want them cleaned up, not ignored. No such files are created during the normal build process.
|
@bors r+ p=5 |
|
📌 Commit 4028a95 has been approved by |
bors
added
the
S-waiting-on-bors
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
@bors r- |
bors
added
S-waiting-on-author
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
let x = bazwhich was obscuring the real error #53129 (removelet x = bazwhich was obscuring the real error)shallow_resolveat its hottest call site. #53513 (Force-inlineshallow_resolveat its hottest call site.)extern cratein 2018 #53684 (rustc: Suggest removingextern cratein 2018)async_identsto all new keywords #53685 (Generalizeasync_identsto all new keywords)unroll_place()in a common case. #53733 (Avoid callingunroll_place()in a common case.)Failed merges:
r? @ghost