-
Notifications
You must be signed in to change notification settings - Fork 13.5k
resolve: Future proof derive helper attributes #54086
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
r? @oli-obk (rust_highfive has picked a reviewer for you, use r? to override) |
@bors p=1 |
☔ The latest upstream changes (presumably #53778) made this pull request unmergeable. Please resolve the merge conflicts. |
a40f076
to
8c49e4a
Compare
@bors: r+ |
📌 Commit 8c49e4a41f9915d38a5802c3f1976f4d42ff51ae has been approved by |
🔒 Merge conflict This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again. How do I rebase?Assuming
You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial. Please avoid the "Resolve conflicts" button on GitHub. It uses Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Error message
|
☔ The latest upstream changes (presumably #53913) made this pull request unmergeable. Please resolve the merge conflicts. |
8c49e4a
to
2b3e98f
Compare
@bors r=alexcrichton |
📌 Commit 2b3e98f has been approved by |
☀️ Test successful - status-appveyor, status-travis |
Derive helpers no longer require going through recovery mode (fixes #53481).
They also report an error if they are ambiguous with any other macro in scope, so we can resolve the question about their exact priority sometime later (cc #52226).