Reexport CheckLintNameResult #54106

flip1995 · 2018-09-10T15:31:56Z

Make the enum CheckLintNameResult public, so that lint tools (aka Clippy) can use it together with LintStore::check_lint_name, to handle the case that a scoped tool_lint doesn't exist in the tool.

This is currently not handled by the compiler:

rust/src/librustc/lint/levels.rs

Lines 309 to 314 in 5953454

    
           Err((None, _)) => { 
        
               // If Tool(Err(None, _)) is returned, then either the lint does not 
        
               // exist in the tool or the code was not compiled with the tool and 
        
               // therefore the lint was never added to the `LintStore`. To detect 
        
               // this is the responsibility of the lint tool. 
        
           }

Needed for rust-lang/rust-clippy#3161

r? @Manishearth

Manishearth · 2018-09-10T15:33:23Z

@bors r+ rollup

bors · 2018-09-10T15:33:25Z

📌 Commit c549e65 has been approved by Manishearth

@Manishearth

…=Manishearth Reexport CheckLintNameResult Make the enum `CheckLintNameResult` public, so that lint tools (aka Clippy) can use it together with [`LintStore::check_lint_name`](https://doc.rust-lang.org/nightly/nightly-rustc/rustc/lint/struct.LintStore.html#method.check_lint_name), to handle the case that a scoped `tool_lint` doesn't exist in the tool. This is currently not handled by the compiler: https://github.com/rust-lang/rust/blob/595345419d12c3ea860151df52f78744a31bafff/src/librustc/lint/levels.rs#L309-L314 Needed for rust-lang/rust-clippy#3161 r? @Manishearth

@ghost

Rollup of 15 pull requests Successful merges: - #52514 (Fix a few AMDGPU related issues) - #53703 (Document .0 to unpack integer from Wrapping) - #53777 (Implemented map_or_else for Result<T, E>) - #54031 (A few cleanups and minor improvements to rustc_passes) - #54046 (Update documentation for fill_buf in std::io::BufRead) - #54064 (`&CStr`, not `CStr`, is the counterpart of `&str`) - #54072 (Stabilization change for mod.rs) - #54073 (docs: Use dollar sign for all bash prompts) - #54074 (simplify ordering for Kind) - #54085 (Remove documentation about proc_macro being bare-bones) - #54087 (rustdoc: Remove generated blanket impls from trait pages) - #54106 (Reexport CheckLintNameResult) - #54107 (Fix typos in libstd hash map) - #54136 (Update LLVM to fix GlobalISel dbg.declare) - #54142 (Recover proper regression test for issue #16278.) Failed merges: r? @ghost

3161: New lint: Unknown clippy lints r=phansch a=flip1995 This is the Clippy version of the `rustc` lint `unknown_lints`. The behavior of this lint is pretty much the same. Before this is merged a small change in the compiler needs to be done: `CheckLintNameResult` needs to be public. See rust-lang/rust#54106 3387: Replace big if/else expression with match r=flip1995 a=mikerite 3388: RIIR update lints: Generate deprecated lints r=phansch a=phansch The update script now also generates the 'register_removed' section in `clippy_lints/src/lib.rs`. Also, instead of using `let mut store ...`, I added a new identifier line so that the replacement will continue to work in case `let mut store ...` ever changes. cc #2882 Co-authored-by: flip1995 <9744647+flip1995@users.noreply.github.com> Co-authored-by: flip1995 <hello@philkrones.com> Co-authored-by: Michael Wright <mikerite@lavabit.com> Co-authored-by: Philipp Hansch <dev@phansch.net>

3161: New lint: Unknown clippy lints r=phansch a=flip1995 This is the Clippy version of the `rustc` lint `unknown_lints`. The behavior of this lint is pretty much the same. Before this is merged a small change in the compiler needs to be done: `CheckLintNameResult` needs to be public. See rust-lang/rust#54106 3387: Replace big if/else expression with match r=flip1995 a=mikerite Co-authored-by: flip1995 <9744647+flip1995@users.noreply.github.com> Co-authored-by: flip1995 <hello@philkrones.com> Co-authored-by: Michael Wright <mikerite@lavabit.com>

3161: New lint: Unknown clippy lints r=phansch a=flip1995 This is the Clippy version of the `rustc` lint `unknown_lints`. The behavior of this lint is pretty much the same. Before this is merged a small change in the compiler needs to be done: `CheckLintNameResult` needs to be public. See rust-lang/rust#54106 Co-authored-by: flip1995 <9744647+flip1995@users.noreply.github.com> Co-authored-by: flip1995 <hello@philkrones.com>

Reexport CheckLintNameResult

c549e65

rust-highfive assigned Manishearth Sep 10, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 10, 2018

flip1995 mentioned this pull request Sep 10, 2018

New lint: Unknown clippy lints rust-lang/rust-clippy#3161

Merged

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 10, 2018

kennytm mentioned this pull request Sep 12, 2018

Rollup of 15 pull requests #54146

Merged

bors merged commit c549e65 into rust-lang:master Sep 12, 2018

flip1995 deleted the pub_checklintnameresult branch September 12, 2018 11:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reexport CheckLintNameResult #54106

Reexport CheckLintNameResult #54106

flip1995 commented Sep 10, 2018

Manishearth commented Sep 10, 2018

bors commented Sep 10, 2018

	Err((None, _)) => {
	// If Tool(Err(None, _)) is returned, then either the lint does not
	// exist in the tool or the code was not compiled with the tool and
	// therefore the lint was never added to the `LintStore`. To detect
	// this is the responsibility of the lint tool.
	}

Reexport CheckLintNameResult #54106

Reexport CheckLintNameResult #54106

Conversation

flip1995 commented Sep 10, 2018

Manishearth commented Sep 10, 2018

bors commented Sep 10, 2018