Impl From<NonZero<T>> for T #54240

csmoe · 2018-09-15T01:49:02Z

Closes #54171

r? @SimonSapin

SimonSapin · 2018-09-15T10:01:26Z

Looks good to me. Let’s get team sign off since impls are insta-stable:

@rfcbot fcp merge

rfcbot · 2018-09-15T10:01:27Z

Team member @SimonSapin has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

scottmcm · 2018-09-17T04:34:52Z

src/test/run-pass/nonzero.rs

+fn main() {
+    use std::num::NonZeroU32;
+    let nz = NonZeroU32::new(5).unwrap();
+    let num: u32 = nz.into();


nit: perhaps just make this a doctest on the impl, so users can see it?

most of the types like String/PathBuf in std doesn't have specific docs for their From implementation, and invoking .from/.into is kind of intuition, so I think that's fine without doctest? but if it's really needed, I'd add it.

Definitely not a need. I just found a run-pass test odd for this, as x.py test src/libcore doesn't run those. src/libcore/tests/nonzero.rs might also be a reasonable place for the test.

src/libcore/tests/nonzero.rs also makes sense to me.

scottmcm · 2018-09-17T04:35:22Z

src/libcore/num/mod.rs

@@ -93,6 +93,13 @@ assert_eq!(size_of::<Option<std::num::", stringify!($Ty), ">>(), size_of::<", st

            }

+            #[stable(feature = "nonzero", since = "1.28.0")]


nit: I think it'll be 1.31 now?

SimonSapin · 2018-09-17T07:58:21Z

The CI failure means this should use a new feature name, something like from_nonzero.

rfcbot · 2018-09-19T18:02:08Z

🔔 This is now entering its final comment period, as per the review above. 🔔

rfcbot · 2018-09-29T18:02:08Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

alexcrichton · 2018-09-29T18:57:19Z

@bors: r+

bors · 2018-09-29T18:57:20Z

📌 Commit 95c1d81 has been approved by alexcrichton

bors · 2018-09-29T19:38:20Z

⌛ Testing commit 95c1d81 with merge bb0896a...

@SimonSapin

Impl From<NonZero<T>> for T Closes #54171 r? @SimonSapin

bors · 2018-09-29T22:19:56Z

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing bb0896a to master...

csmoe added 2 commits September 15, 2018 09:34

implement From<NonZero<Int>> for Int

d5c1d15

add run-pass test for From<NonZero>

f451580

rust-highfive assigned SimonSapin Sep 15, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 15, 2018

kennytm added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. relnotes Marks issues that should be documented in the release notes of the next release. labels Sep 15, 2018

rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Sep 15, 2018

scottmcm reviewed Sep 17, 2018

View reviewed changes

This comment has been minimized.

# to view

introduce from_nonzero feature

ac61a9c

csmoe force-pushed the nonzero_from branch from 29d2579 to c5d6478 Compare September 17, 2018 08:35

This comment has been minimized.

# to view

csmoe force-pushed the nonzero_from branch from c5d6478 to 57b0da8 Compare September 17, 2018 09:56

move from_nonzero test from run-pass to libcore

95c1d81

csmoe force-pushed the nonzero_from branch from 57b0da8 to 95c1d81 Compare September 17, 2018 10:02

rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Sep 19, 2018

rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Sep 29, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 29, 2018

bors added a commit that referenced this pull request Sep 29, 2018

Auto merge of #54240 - csmoe:nonzero_from, r=alexcrichton

bb0896a

Impl From<NonZero<T>> for T Closes #54171 r? @SimonSapin

bors merged commit 95c1d81 into rust-lang:master Sep 29, 2018

csmoe deleted the nonzero_from branch September 29, 2018 23:33

Centril added this to the 1.31 milestone Apr 26, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Impl From<NonZero<T>> for T #54240

Impl From<NonZero<T>> for T #54240

Uh oh!

csmoe commented Sep 15, 2018 •

edited

Loading

Uh oh!

SimonSapin commented Sep 15, 2018

Uh oh!

rfcbot commented Sep 15, 2018 •

edited by Kimundi

Loading

Uh oh!

scottmcm Sep 17, 2018

Uh oh!

csmoe Sep 17, 2018

Uh oh!

scottmcm Sep 17, 2018

Uh oh!

SimonSapin Sep 17, 2018

Uh oh!

scottmcm Sep 17, 2018

Uh oh!

This comment has been minimized.

SimonSapin commented Sep 17, 2018

Uh oh!

This comment has been minimized.

rfcbot commented Sep 19, 2018

Uh oh!

rfcbot commented Sep 29, 2018

Uh oh!

alexcrichton commented Sep 29, 2018

Uh oh!

bors commented Sep 29, 2018

Uh oh!

bors commented Sep 29, 2018

Uh oh!

bors commented Sep 29, 2018

Uh oh!

Uh oh!

		@@ -93,6 +93,13 @@ assert_eq!(size_of::<Option<std::num::", stringify!($Ty), ">>(), size_of::<", st

		}

		#[stable(feature = "nonzero", since = "1.28.0")]

Impl From<NonZero<T>> for T #54240

Impl From<NonZero<T>> for T #54240

Uh oh!

Conversation

csmoe commented Sep 15, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SimonSapin commented Sep 15, 2018

Uh oh!

rfcbot commented Sep 15, 2018 • edited by Kimundi Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

scottmcm Sep 17, 2018

Choose a reason for hiding this comment

Uh oh!

csmoe Sep 17, 2018

Choose a reason for hiding this comment

Uh oh!

scottmcm Sep 17, 2018

Choose a reason for hiding this comment

Uh oh!

SimonSapin Sep 17, 2018

Choose a reason for hiding this comment

Uh oh!

scottmcm Sep 17, 2018

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

SimonSapin commented Sep 17, 2018

Uh oh!

This comment has been minimized.

rfcbot commented Sep 19, 2018

Uh oh!

rfcbot commented Sep 29, 2018

Uh oh!

alexcrichton commented Sep 29, 2018

Uh oh!

bors commented Sep 29, 2018

Uh oh!

bors commented Sep 29, 2018

Uh oh!

bors commented Sep 29, 2018

Uh oh!

Uh oh!

csmoe commented Sep 15, 2018 •

edited

Loading

rfcbot commented Sep 15, 2018 •

edited by Kimundi

Loading