-
Notifications
You must be signed in to change notification settings - Fork 13.4k
[rustdoc] Add lint for doc without codeblocks #54349
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
7aa21cd
to
1256963
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Just a couple comments and this looks good.
I wonder whether it's possible to copy out some of the lint registration mechanisms and start hosting them ourselves.
src/librustc/lint/builtin.rs
Outdated
@@ -312,6 +312,12 @@ declare_lint! { | |||
"warn about documentation intra links resolution failure" | |||
} | |||
|
|||
declare_lint! { | |||
pub MISSING_DOC_ITEM_CODE_EXAMPLE, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may work better as MISSING_DOC_CODE_EXAMPLES
- users don't need to care about the fact that docs go on items, and making it plural fits in better with other lints.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I indeed prefer the new proposition. :)
1256963
to
f23cda1
Compare
Updated. |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
f23cda1
to
47872ad
Compare
And removed unwanted change. All ready to go now! |
Thanks! Can you add a test? Sorry for not noticing earlier. |
47872ad
to
c0b7b6e
Compare
Rebased and added the test. |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
c0b7b6e
to
26479c4
Compare
And fixed tidy. |
Thanks so much! @bors r+ |
📌 Commit 26479c4 has been approved by |
⌛ Testing commit 26479c4 with merge 021f0915c2b3f12a0b64cb96d90c40377edf64f2... |
💔 Test failed - status-travis |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
@bors retry Linker SIGILL |
⌛ Testing commit 26479c4 with merge 151e4590f5fdb15fd6f8780e881eb5fb9ed8af58... |
💔 Test failed - status-travis |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
[rustdoc] Add lint for doc without codeblocks Fixes #53805. r? @QuietMisdreavus
☀️ Test successful - status-appveyor, status-travis |
Fixes #53805.
r? @QuietMisdreavus