add test for #23189 #54991
add test for #23189 #54991
Conversation
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
| } | ||
|
|
||
| fn main() { | ||
| let _ = module { x: 0 }; //~ERROR cannot find struct |
There was a problem hiding this comment.
After looking at the original issue, I'm wondering if the ICE only triggered when the name module was in scope. Putting it under auxiliary would change that.
Did you manage to reproduce the original ICE with this test?
|
Thanks for your PR! I did some checking, and I think you need a Note that you can pull the compiler from the original issue with rustup: |
|
r? @tmandry |
tmandry
added
S-waiting-on-author
|
Thanks for the review. I found that the auxiliary module isn't actually necessary at all, so I pushed a simplified test case. |
|
Nice, even better! @bors r+ rollup |
|
📌 Commit 3855af5 has been approved by |
bors
added
S-waiting-on-bors
Rollup of 11 pull requests Successful merges: - #54820 (Closes #54538: `unused_patterns` lint) - #54963 (Cleanup rustc/session) - #54991 (add test for #23189) - #55025 (Add missing lifetime fragment specifier to error message.) - #55047 (doc: make core::fmt::Error example more simple) - #55048 (Don't collect to vectors where unnecessary) - #55060 (clarify pointer add/sub function safety concerns) - #55062 (Make EvalContext::step public again) - #55066 (Fix incorrect link in println! documentation) - #55081 (Deduplicate tests) - #55088 (Update rustc documentation link) Failed merges: r? @ghost
Fixes #23189