Skip to content

Make sure the aws executable is in $PATH on macOS #55573

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Nov 1, 2018

Conversation

kennytm
Copy link
Member

@kennytm kennytm commented Nov 1, 2018

Fixes #55571

@kennytm
Copy link
Member Author

kennytm commented Nov 1, 2018

@bors try

@bors
Copy link
Collaborator

bors commented Nov 1, 2018

⌛ Trying commit f3592a9 with merge 247c3ff...

bors added a commit that referenced this pull request Nov 1, 2018
[WIP] Make sure the `aws` executable in in $PATH on macOS
@bors
Copy link
Collaborator

bors commented Nov 1, 2018

☀️ Test successful - status-travis
State: approved= try=True

@kennytm kennytm changed the title [WIP] Make sure the aws executable in in $PATH on macOS Make sure the aws executable in in $PATH on macOS Nov 1, 2018
@kennytm
Copy link
Member Author

kennytm commented Nov 1, 2018

r? @alexcrichton

@kennytm kennytm changed the title Make sure the aws executable in in $PATH on macOS Make sure the aws executable is in $PATH on macOS Nov 1, 2018
@alexcrichton
Copy link
Member

@bors: r+ p=1

I thought I checked this :(

@bors
Copy link
Collaborator

bors commented Nov 1, 2018

📌 Commit a854677 has been approved by alexcrichton

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Nov 1, 2018
kennytm added a commit to pietroalbini/rust that referenced this pull request Nov 1, 2018
Make sure the `aws` executable is in $PATH on macOS

Fixes rust-lang#55571
bors added a commit that referenced this pull request Nov 1, 2018
Rollup of 13 pull requests

Successful merges:

 - #55280 (Add libproc_macro to rust-src distribution)
 - #55469 (Regression tests for issue #54477.)
 - #55504 (Use vec![x; n] instead of iter::repeat(x).take(n).collect())
 - #55522 (use String::from() instead of format!() macro to construct Strings.)
 - #55536 (Pass suggestions as impl Iterator instead of Vec)
 - #55542 (syntax: improve a few allocations)
 - #55558 (Tweak `MatcherPos::matches`)
 - #55561 (Fix double_check tests on big-endian targets)
 - #55573 (Make sure the `aws` executable is in $PATH on macOS)
 - #55574 (Use `SmallVec` within `MoveData`.)
 - #55575 (Fix invalid_const_promotion test on some archs)
 - #55578 (Made doc example of `impl Default for …` use `-> Self` instead of explicit self type)
 - #55582 (Remove unused import copy from publish_toolstate.py)
@bors bors merged commit a854677 into rust-lang:master Nov 1, 2018
@alexcrichton alexcrichton added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Nov 9, 2018
bors added a commit that referenced this pull request Nov 10, 2018
[beta] Make sure the installed `awscli` is found on macOS.

This is a backport of #55573 which...

Closes #55817
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants