Skip to content

Fixed the bug in bootstrap where --exclude was ignored for run-pass test #55661

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 3, 2018
Merged

Fixed the bug in bootstrap where --exclude was ignored for run-pass test #55661

merged 2 commits into from
Nov 3, 2018

Conversation

kennytm
Copy link
Member

@kennytm kennytm commented Nov 3, 2018 •
edited
Loading

This should fix the 3 hour timeout on AppVeyor which happened a lot recently.

Additionally, further rebalanced the AppVeyor subsets by moving "ui" and "linkchecker" into Set 2.

@kennytm
Ensure --exclude is checked against PathSet::Suite
a257332 
Fix the recent spurious 3 hour timeouts.
@kennytm
Move a few more tests into the appveyor-subset-2.
2bde4e7 
This should allow the timings be more balanced.
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 3, 2018
@alexcrichton
Copy link
Member

@bors: r+ p=1

@bors
Copy link
Collaborator

bors commented Nov 3, 2018

📌 Commit 2bde4e7 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 3, 2018
@bors
Copy link
Collaborator

bors commented Nov 3, 2018

⌛ Testing commit 2bde4e7 with merge 04fdb44...

bors added a commit that referenced this pull request Nov 3, 2018
@bors
Auto merge of #55661 - kennytm:fix-exclude, r=alexcrichton
04fdb44 
Fixed the bug in bootstrap where --exclude was ignored for run-pass test

This should fix the 3 hour timeout on AppVeyor which happened a lot recently.

Additionally, further rebalanced the AppVeyor subsets by moving "ui" and "linkchecker" into Set 2.
@bors
Copy link
Collaborator

bors commented Nov 3, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 04fdb44 to master...

@bors bors merged commit 2bde4e7 into rust-lang:master Nov 3, 2018
@alexcrichton alexcrichton mentioned this pull request Nov 8, 2018
Merged
bors added a commit that referenced this pull request Nov 8, 2018
@bors
Auto merge of #55611 - alexcrichton:beta-next, r=alexcrichton
bf00632 
[beta] Fixes #46775 -- don't mutate the process's environment in Command::exec

This is a backport of the following PRs:

* #55359
* #55569
* #55304
* #55661
@alexcrichton alexcrichton added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Nov 8, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kennytm @alexcrichton @bors @rust-highfive