Typecheck patterns of all match arms first, so we get types for bindings #55819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @estebank (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
pnkfelix
added
the
beta-nominated
|
Might this PR fix this issue? #55820 |
|
@bors r+ |
|
📌 Commit 5f91373 has been approved by |
bors
added
S-waiting-on-bors
estebank
added
beta-accepted
|
Accepting for backport. |
pietroalbini
added
the
beta-nominated
pietroalbini
added a commit
to pietroalbini/rust
that referenced
this pull request
Nov 10, 2018
…ts-eagerly, r=oli-obk Typecheck patterns of all match arms first, so we get types for bindings Fix eventually (after backport to beta) the issue rust-lang#55810
bors
added a commit
that referenced
this pull request
Nov 11, 2018
Rollup of 17 pull requests Successful merges: - #55630 (resolve: Filter away macro prelude in modules with `#[no_implicit_prelude]` on 2018 edition) - #55687 (Take supertraits into account when calculating associated types) - #55745 (Convert `outlives_components`' return value to a `SmallVec` outparam.) - #55764 (Fix Rc/Arc allocation layout) - #55792 (Prevent ICE in const-prop array oob check) - #55799 (Removed unneeded instance of `// revisions` from a lint test) - #55800 (Fix ICE in `return_type_impl_trait`) - #55801 (NLL: Update box insensitivity test) - #55802 (Don't inline virtual calls (take 2)) - #55816 (Use `SmallVec` to avoid allocations in `from_decimal_string`.) - #55819 (Typecheck patterns of all match arms first, so we get types for bindings) - #55822 (ICE with #![feature(nll)] and elided lifetimes) - #55828 (Add missing `rustc_promotable` attribute to unsigned `min_value` and `max_value`) - #55839 (Fix docstring spelling mistakes) - #55844 (Fix documentation typos.) - #55845 (Set BINARYEN_TRAP_MODE=clamp) - #55856 (rustdoc: refactor: move all static-file include!s into a single module)
|
☔ The latest upstream changes (presumably #55859) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
pietroalbini
removed
the
beta-nominated
eddyb
reviewed
Nov 14, 2018
| // bindings. | ||
| let all_arm_pats_diverge = arms.iter().map(|arm| { | ||
| // rust-lang/rust#55810: Typecheck patterns first (via eager | ||
| // collection into `Vec`), so we get types for all bindings. |
There was a problem hiding this comment.
Ahh, had I seen this PR, I would've suggested adding a note that the map below has side-effects in terms of type inference (unifying the types of all the arms together), and that's why it has to fully complete first.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix eventually (after backport to beta) the issue #55810