-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Add std::iter::unfold #55869
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Merged
Merged
Add std::iter::unfold #55869
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
48aae09
Add std::iter::unfold
SimonSapin 544ad37
Unfold<St, F>: Debug without F: Debug
SimonSapin 2222818
`Copy` is best avoided on iterators
SimonSapin 641c490
Add std::iter::successors
SimonSapin 8a5bbd9
Add tracking issue for unfold and successors
SimonSapin a4279a0
Capitalize
SimonSapin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -386,3 +386,164 @@ impl<T> FusedIterator for Once<T> {} | |
pub fn once<T>(value: T) -> Once<T> { | ||
Once { inner: Some(value).into_iter() } | ||
} | ||
|
||
/// Creates a new iterator where each iteration calls the provided closure | ||
/// `F: FnMut(&mut St) -> Option<T>`. | ||
/// | ||
/// This allows creating a custom iterator with any behavior | ||
/// without using the more verbose syntax of creating a dedicated type | ||
/// and implementing the `Iterator` trait for it. | ||
/// | ||
/// In addition to its captures and environment, | ||
/// the closure is given a mutable reference to some state | ||
/// that is preserved across iterations. | ||
/// That state starts as the given `initial_state` value. | ||
/// | ||
/// Note that the `Unfold` iterator doesn’t make assumptions about the behavior of the closure, | ||
/// and therefore conservatively does not implement [`FusedIterator`], | ||
/// or override [`Iterator::size_hint`] from its default `(0, None)`. | ||
/// | ||
/// [`FusedIterator`]: trait.FusedIterator.html | ||
/// [`Iterator::size_hint`]: trait.Iterator.html#method.size_hint | ||
/// | ||
/// # Examples | ||
/// | ||
/// Let’s re-implement the counter iterator from [module-level documentation]: | ||
/// | ||
/// [module-level documentation]: index.html | ||
/// | ||
/// ``` | ||
/// #![feature(iter_unfold)] | ||
/// let counter = std::iter::unfold(0, |count| { | ||
/// // Increment our count. This is why we started at zero. | ||
/// *count += 1; | ||
/// | ||
/// // Check to see if we've finished counting or not. | ||
/// if *count < 6 { | ||
/// Some(*count) | ||
/// } else { | ||
/// None | ||
/// } | ||
/// }); | ||
/// assert_eq!(counter.collect::<Vec<_>>(), &[1, 2, 3, 4, 5]); | ||
/// ``` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe leave a note that this iterator is not fused and that calling it after it returned There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe also leave a note about |
||
#[inline] | ||
#[unstable(feature = "iter_unfold", issue = "55977")] | ||
pub fn unfold<St, T, F>(initial_state: St, f: F) -> Unfold<St, F> | ||
where F: FnMut(&mut St) -> Option<T> | ||
{ | ||
Unfold { | ||
state: initial_state, | ||
f, | ||
} | ||
} | ||
|
||
/// An iterator where each iteration calls the provided closure `F: FnMut(&mut St) -> Option<T>`. | ||
/// | ||
/// This `struct` is created by the [`unfold`] function. | ||
/// See its documentation for more. | ||
/// | ||
/// [`unfold`]: fn.unfold.html | ||
#[derive(Clone)] | ||
#[unstable(feature = "iter_unfold", issue = "55977")] | ||
pub struct Unfold<St, F> { | ||
state: St, | ||
f: F, | ||
} | ||
|
||
#[unstable(feature = "iter_unfold", issue = "55977")] | ||
impl<St, T, F> Iterator for Unfold<St, F> | ||
where F: FnMut(&mut St) -> Option<T> | ||
{ | ||
type Item = T; | ||
|
||
#[inline] | ||
fn next(&mut self) -> Option<Self::Item> { | ||
(self.f)(&mut self.state) | ||
} | ||
} | ||
|
||
#[unstable(feature = "iter_unfold", issue = "55977")] | ||
impl<St: fmt::Debug, F> fmt::Debug for Unfold<St, F> { | ||
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { | ||
f.debug_struct("Unfold") | ||
.field("state", &self.state) | ||
.finish() | ||
} | ||
} | ||
|
||
/// Creates a new iterator where each successive item is computed based on the preceding one. | ||
/// | ||
/// The iterator starts with the given first item (if any) | ||
/// and calls the given `FnMut(&T) -> Option<T>` closure to compute each item’s successor. | ||
/// | ||
/// ``` | ||
/// #![feature(iter_unfold)] | ||
/// use std::iter::successors; | ||
/// | ||
/// let powers_of_10 = successors(Some(1_u16), |n| n.checked_mul(10)); | ||
/// assert_eq!(powers_of_10.collect::<Vec<_>>(), &[1, 10, 100, 1_000, 10_000]); | ||
/// ``` | ||
#[unstable(feature = "iter_unfold", issue = "55977")] | ||
pub fn successors<T, F>(first: Option<T>, succ: F) -> Successors<T, F> | ||
where F: FnMut(&T) -> Option<T> | ||
{ | ||
// If this function returned `impl Iterator<Item=T>` | ||
// it could be based on `unfold` and not need a dedicated type. | ||
// However having a named `Successors<T, F>` type allows it to be `Clone` when `T` and `F` are. | ||
Successors { | ||
next: first, | ||
succ, | ||
} | ||
} | ||
|
||
/// An new iterator where each successive item is computed based on the preceding one. | ||
/// | ||
/// This `struct` is created by the [`successors`] function. | ||
/// See its documentation for more. | ||
/// | ||
/// [`successors`]: fn.successors.html | ||
#[derive(Clone)] | ||
#[unstable(feature = "iter_unfold", issue = "55977")] | ||
pub struct Successors<T, F> { | ||
next: Option<T>, | ||
succ: F, | ||
} | ||
|
||
#[unstable(feature = "iter_unfold", issue = "55977")] | ||
impl<T, F> Iterator for Successors<T, F> | ||
where F: FnMut(&T) -> Option<T> | ||
{ | ||
type Item = T; | ||
|
||
#[inline] | ||
fn next(&mut self) -> Option<Self::Item> { | ||
self.next.take().map(|item| { | ||
self.next = (self.succ)(&item); | ||
item | ||
}) | ||
} | ||
|
||
#[inline] | ||
fn size_hint(&self) -> (usize, Option<usize>) { | ||
if self.next.is_some() { | ||
(1, None) | ||
} else { | ||
(0, Some(0)) | ||
} | ||
} | ||
} | ||
|
||
#[unstable(feature = "iter_unfold", issue = "55977")] | ||
impl<T, F> FusedIterator for Successors<T, F> | ||
where F: FnMut(&T) -> Option<T> | ||
{} | ||
|
||
#[unstable(feature = "iter_unfold", issue = "55977")] | ||
impl<T: fmt::Debug, F> fmt::Debug for Successors<T, F> { | ||
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { | ||
f.debug_struct("Successors") | ||
.field("next", &self.next) | ||
.finish() | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.