do not propagate inferred bounds on trait objects if they involve Self
#56003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikomatsakis
added
the
beta-nominated
rust-highfive
added
the
S-waiting-on-review
|
Urgh, rebasing. |
eddyb
approved these changes
Nov 16, 2018
|
r=me |
nikomatsakis
force-pushed
the
issue-54467-infer-outlives-bounds-and-trait-objects
branch
from
21d4688 to
6575988
Compare
|
@bors r=eddyb |
|
📌 Commit 6575988 has been approved by |
bors
added
S-waiting-on-bors
|
@bors p=1 -- regression, rust-2018, etc |
|
💔 Test failed - status-appveyor |
bors
added
S-waiting-on-review
|
@bors retry Seems spurious. |
bors
added
S-waiting-on-bors
FWIW, I think I fixed this particular error in the latest cargo (once #55999 lands, fixed by rust-lang/cargo#6292). I'm a little concerned because this coincidentally happened earlier today (rust-lang/cargo#6319), and these are the first occurrences I'm aware of since that test was added 7 months ago. Hopefully it will be fixed. Would you mind pinging me whenever you see a spurious cargo error? I've been trying to get cargo's tests to be more reliable, and any data is helpful. |
|
⌛ Testing commit 6575988 with merge e4927b4c0488c6a6c32ad45e933c3f8ad71ef3c5... |
|
💔 Test failed - status-appveyor |
bors
added
S-waiting-on-review
|
@bors: retry |
bors
removed
the
S-waiting-on-review
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - status-appveyor, status-travis |
nikomatsakis
added
the
beta-accepted
alexcrichton
removed
the
beta-nominated
This was referenced Nov 20, 2018
Merged
bors
added a commit
that referenced
this pull request
Nov 20, 2018
beta backport rollup Backports of some beta-approved PRs - [x] #55385: NLL: cast causes failure to promote to static - [x] #56043: remove "approx env bounds" if we already know from trait - [x] #56003: do not propagate inferred bounds on trait objects if they involve `Self` - [x] #55852: Rewrite `...` as `..=` as a `MachineApplicable` 2018 idiom lint - [x] #55804: rustdoc: don't inline `pub use some_crate` unless directly asked to - [x] #56059: Increase `Duration` approximate equal threshold to 1us - [x] Keep resolved defs in path prefixes and emit them in save-analysis #54145 - [x] Adjust Ids of path segments in visibility modifiers #55487 - [x] save-analysis: bug fix and optimisation. #55521 - [x] save-analysis: be even more aggressive about ignorning macro-generated defs #55936 - [x] save-analysis: fallback to using path id #56060 - [x] save-analysis: Don't panic for macro-generated use globs #55879 - [x] Add temporary renames to manifests for rustfmt/clippy #56081 - [x] Revert #51601 #56049 - [x] Fix stability hole with `static _` #55983 - [x] #56077 - [x] Fix Rustdoc ICE when checking blanket impls #55258 - [x] Updated RELEASES.md for 1.31.0 #55678 - [x] ~~#56061~~ #56111 - [x] Stabilize `extern_crate_item_prelude` #56032 Still running tests locally, and I plan to backport @nrc's other PRs too (cc @petrochenkov -- thanks for the advice)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54467, which is a Rust 2018 Release blocking issue.
r? @eddyb