Skip to content

codegen_utils, driver: fix clippy errors #56566

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Dec 7, 2018

Conversation

ljedrz
Copy link
Contributor

@ljedrz ljedrz commented Dec 6, 2018

  • remove a superfluous conversion
  • remove an explicit return
  • rename MetadataOnlyCodegenBackend::new to ::boxed
  • single-arm match > if let

@rust-highfive
Copy link
Contributor

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 6, 2018
@cramertj
Copy link
Member

cramertj commented Dec 6, 2018

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 6, 2018

📌 Commit 0142126160ce9ee50de426606379c466f4380845 has been approved by cramertj

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 6, 2018
@rust-highfive

This comment has been minimized.

@ljedrz ljedrz force-pushed the fix_clippy_errors branch from 0142126 to adaeb10 Compare December 6, 2018 20:14
@ljedrz
Copy link
Contributor Author

ljedrz commented Dec 6, 2018

Fixed the test.

@kennytm
Copy link
Member

kennytm commented Dec 7, 2018

@bors r=cramertj

@bors
Copy link
Collaborator

bors commented Dec 7, 2018

📌 Commit adaeb10 has been approved by cramertj

@bors
Copy link
Collaborator

bors commented Dec 7, 2018

⌛ Testing commit adaeb10 with merge 1c3236a...

bors added a commit that referenced this pull request Dec 7, 2018
codegen_utils, driver: fix clippy errors

- remove a superfluous conversion
- remove an explicit `return`
- rename `MetadataOnlyCodegenBackend::new` to `::boxed`
- single-arm `match` > `if let`
@bors
Copy link
Collaborator

bors commented Dec 7, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: cramertj
Pushing 1c3236a to master...

@bors bors merged commit adaeb10 into rust-lang:master Dec 7, 2018
@ljedrz ljedrz deleted the fix_clippy_errors branch December 7, 2018 17:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants