Bump minimum required LLVM version to 6.0 #56642

nikic · 2018-12-09T10:34:32Z

Based on the discussion in #55842, while the overall position of Rust wrt LLVM continues to be contentious, there does seem to be a consensus that there is no need for continued support of LLVM 5. This PR bumps our version requirement to LLVM 6.0 and makes Travis run against that.

I hope that this is going to unblock #52694. If I understand correctly, while this issue still exists in LLVM 6, Ubuntu has backported the relevant patch.

r? @alexcrichton

alexcrichton · 2018-12-10T03:33:40Z

@bors: r+

bors · 2018-12-10T03:33:41Z

📌 Commit 706e67b has been approved by alexcrichton

gnzlbg · 2018-12-10T09:35:41Z

@nikic thank you!

petrochenkov · 2018-12-10T11:00:50Z

The proprietary custom target I care about recently migrated to LLVM 6, so this is not an immediate problem to me, but I still find the tendency (#55842) worrying.

I think release_date(LLVM N.0.1) + 1 year or something like that would be a good conservative estimate for making LLVM N the minimum version in rustc, e.g. for LLVM 6 that would mean Jul 5 2019.

gnzlbg · 2018-12-10T11:30:09Z

Does that mean that for you it would be acceptable if Rust supported the last ~3 LLVM versions ?

E.g. in August 2019 LLVM 9 will be released, and if by then Rust supported LLVM >=7 that would be ok ?

petrochenkov · 2018-12-10T11:49:37Z

@gnzlbg
Oh, sorry, off-by-one error. Fixed.
LLVM 7.0.1 is not yet released (but should be released soon, say December 2018), so in December 2019 my formula would allow making LLVM 7 minimum version.
So I don't care about the number of last LLVM versions, only about time passed since release of LLVM N.0.1.

gnzlbg · 2018-12-10T12:47:38Z

I see. I think you already mentioned that in the issue, but if not, could you mention it there ? (~one year after the x.0.1 release) ?

cuviper · 2018-12-11T01:58:19Z

The env_alloca hack can go away again -- roughly reverting #53239.

This is no longer necessary for LLVM >= 6.

nikic · 2018-12-11T11:08:14Z

@cuviper Thanks for pointing that out, I've included the removal of the env_alloca hack.

@bors r=alexcrichton

bors · 2018-12-11T11:08:16Z

📌 Commit 6c2d704 has been approved by alexcrichton

bors · 2018-12-16T02:58:11Z

⌛ Testing commit 6c2d704 with merge 58cdbb9e20750e77eccd9ad41c51231532cd713e...

bors · 2018-12-16T06:58:11Z

💥 Test timed out

kennytm · 2018-12-16T08:07:40Z

@bors retry

https://www.traviscistatus.com/incidents/tmr79p73q6j8

bors · 2018-12-16T08:07:51Z

⌛ Testing commit 6c2d704 with merge 3e3746096b347db27e2685e6155dd86275031fac...

pietroalbini · 2018-12-16T11:48:08Z

@bors retry https://www.traviscistatus.com/incidents/tmr79p73q6j8

bors · 2018-12-16T16:46:23Z

💥 Test timed out

pietroalbini · 2018-12-16T16:49:11Z

@bors retry

bors · 2018-12-16T23:23:14Z

⌛ Testing commit 6c2d704 with merge f53a69d...

@alexcrichton

Bump minimum required LLVM version to 6.0 Based on the discussion in #55842, while the overall position of Rust wrt LLVM continues to be contentious, there does seem to be a consensus that there is no need for continued support of LLVM 5. This PR bumps our version requirement to LLVM 6.0 and makes Travis run against that. I hope that this is going to unblock #52694. If I understand correctly, while this issue still exists in LLVM 6, Ubuntu has backported the relevant patch. r? @alexcrichton

bors · 2018-12-17T01:00:08Z

💔 Test failed - status-travis

rust-highfive · 2018-12-17T01:00:09Z

The job arm-android of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[01:33:32] test string::test_split_off_unicode ... ok
[01:33:32] test string::test_str_truncate ... ok
[01:33:32] test string::test_str_truncate_invalid_len ... ok
[01:33:32] test string::test_str_truncate_split_codepoint ... ok
[01:33:32] died due to signal 11
[01:33:32] 
[01:33:32] 
[01:33:32] 
[01:33:32] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "arm-linux-androideabi" "-j" "4" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "-p" "alloc" "--"
[01:33:32] 
[01:33:32] 
[01:33:32] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --target arm-linux-androideabi
[01:33:32] Build completed unsuccessfully in 1:19:30
---
travis_time:end:05555be0:start=1545008328169123060,finish=1545008328183846998,duration=14723938
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:176e11ba
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0f90cd78
travis_time:start:0f90cd78
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:12373d68
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

kennytm · 2018-12-17T04:08:19Z

@bors retry

bors · 2018-12-17T04:18:21Z

⌛ Testing commit 6c2d704 with merge 63f8e6e...

@alexcrichton

Bump minimum required LLVM version to 6.0 Based on the discussion in #55842, while the overall position of Rust wrt LLVM continues to be contentious, there does seem to be a consensus that there is no need for continued support of LLVM 5. This PR bumps our version requirement to LLVM 6.0 and makes Travis run against that. I hope that this is going to unblock #52694. If I understand correctly, while this issue still exists in LLVM 6, Ubuntu has backported the relevant patch. r? @alexcrichton

bors · 2018-12-17T06:33:58Z

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 63f8e6e to master...

Pkgsrc changes: * Bump required rust version to build to 1.32.0. * Adapt patches to changed file locations. * Since we now patch some more vendor/ modules, doctor the corresponding .cargo-checksum.json files accordingly Upstream changes: Version 1.33.0 (2019-02-28) ========================== Language -------- - [You can now use the `cfg(target_vendor)` attribute.][57465] E.g. `#[cfg(target_vendor="apple")] fn main() { println!("Hello Apple!"); }` - [Integer patterns such as in a match expression can now be exhaustive.][56362] E.g. You can have match statement on a `u8` that covers `0..=255` and you would no longer be required to have a `_ => unreachable!()` case. - [You can now have multiple patterns in `if let` and `while let` expressions.][57532] You can do this with the same syntax as a `match` expression. E.g. ```rust enum Creature { Crab(String), Lobster(String), Person(String), } fn main() { let state = Creature::Crab("Ferris"); if let Creature::Crab(name) | Creature::Person(name) = state { println!("This creature's name is: {}", name); } } ``` - [You can now have irrefutable `if let` and `while let` patterns.][57535] Using this feature will by default produce a warning as this behaviour can be unintuitive. E.g. `if let _ = 5 {}` - [You can now use `let` bindings, assignments, expression statements, and irrefutable pattern destructuring in const functions.][57175] - [You can now call unsafe const functions.][57067] E.g. ```rust const unsafe fn foo() -> i32 { 5 } const fn bar() -> i32 { unsafe { foo() } } ``` - [You can now specify multiple attributes in a `cfg_attr` attribute.][57332] E.g. `#[cfg_attr(all(), must_use, optimize)]` - [You can now specify a specific alignment with the `#[repr(packed)]` attribute.][57049] E.g. `#[repr(packed(2))] struct Foo(i16, i32);` is a struct with an alignment of 2 bytes and a size of 6 bytes. - [You can now import an item from a module as an `_`.][56303] This allows you to import a trait's impls, and not have the name in the namespace. E.g. ```rust use std::io::Read as _; // Allowed as there is only one `Read` in the module. pub trait Read {} ``` - [You may now use `Rc`, `Arc`, and `Pin` as method receivers][56805]. Compiler -------- - [You can now set a linker flavor for `rustc` with the `-Clinker-flavor` command line argument.][56351] - [The mininum required LLVM version has been bumped to 6.0.][56642] - [Added support for the PowerPC64 architecture on FreeBSD.][57615] - [The `x86_64-fortanix-unknown-sgx` target support has been upgraded to tier 2 support.][57130] Visit the [platform support][platform-support] page for information on Rust's platform support. - [Added support for the `thumbv7neon-linux-androideabi` and `thumbv7neon-unknown-linux-gnueabihf` targets.][56947] - [Added support for the `x86_64-unknown-uefi` target.][56769] Libraries --------- - [The methods `overflowing_{add, sub, mul, shl, shr}` are now `const` functions for all numeric types.][57566] - [The methods `rotate_left`, `rotate_right`, and `wrapping_{add, sub, mul, shl, shr}` are now `const` functions for all numeric types.][57105] - [The methods `is_positive` and `is_negative` are now `const` functions for all signed numeric types.][57105] - [The `get` method for all `NonZero` types is now `const`.][57167] - [The methods `count_ones`, `count_zeros`, `leading_zeros`, `trailing_zeros`, `swap_bytes`, `from_be`, `from_le`, `to_be`, `to_le` are now `const` for all numeric types.][57234] - [`Ipv4Addr::new` is now a `const` function][57234] Stabilized APIs --------------- - [`unix::FileExt::read_exact_at`] - [`unix::FileExt::write_all_at`] - [`Option::transpose`] - [`Result::transpose`] - [`convert::identity`] - [`pin::Pin`] - [`marker::Unpin`] - [`marker::PhantomPinned`] - [`Vec::resize_with`] - [`VecDeque::resize_with`] - [`Duration::as_millis`] - [`Duration::as_micros`] - [`Duration::as_nanos`] Cargo ----- - [Cargo should now rebuild a crate if a file was modified during the initial build.][cargo/6484] Compatibility Notes ------------------- - The methods `str::{trim_left, trim_right, trim_left_matches, trim_right_matches}` are now deprecated in the standard library, and their usage will now produce a warning. Please use the `str::{trim_start, trim_end, trim_start_matches, trim_end_matches}` methods instead. - The `Error::cause` method has been deprecated in favor of `Error::source` which supports downcasting. [55982]: rust-lang/rust#55982 [56303]: rust-lang/rust#56303 [56351]: rust-lang/rust#56351 [56362]: rust-lang/rust#56362 [56642]: rust-lang/rust#56642 [56769]: rust-lang/rust#56769 [56805]: rust-lang/rust#56805 [56947]: rust-lang/rust#56947 [57049]: rust-lang/rust#57049 [57067]: rust-lang/rust#57067 [57105]: rust-lang/rust#57105 [57130]: rust-lang/rust#57130 [57167]: rust-lang/rust#57167 [57175]: rust-lang/rust#57175 [57234]: rust-lang/rust#57234 [57332]: rust-lang/rust#57332 [57465]: rust-lang/rust#57465 [57532]: rust-lang/rust#57532 [57535]: rust-lang/rust#57535 [57566]: rust-lang/rust#57566 [57615]: rust-lang/rust#57615 [cargo/6484]: rust-lang/cargo#6484 [`unix::FileExt::read_exact_at`]: https://doc.rust-lang.org/std/os/unix/fs/trait.FileExt.html#method.read_exact_at [`unix::FileExt::write_all_at`]: https://doc.rust-lang.org/std/os/unix/fs/trait.FileExt.html#method.write_all_at [`Option::transpose`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.transpose [`Result::transpose`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.transpose [`convert::identity`]: https://doc.rust-lang.org/std/convert/fn.identity.html [`pin::Pin`]: https://doc.rust-lang.org/std/pin/struct.Pin.html [`marker::Unpin`]: https://doc.rust-lang.org/stable/std/marker/trait.Unpin.html [`marker::PhantomPinned`]: https://doc.rust-lang.org/nightly/std/marker/struct.PhantomPinned.html [`Vec::resize_with`]: https://doc.rust-lang.org/std/vec/struct.Vec.html#method.resize_with [`VecDeque::resize_with`]: https://doc.rust-lang.org/std/collections/struct.VecDeque.html#method.resize_with [`Duration::as_millis`]: https://doc.rust-lang.org/std/time/struct.Duration.html#method.as_millis [`Duration::as_micros`]: https://doc.rust-lang.org/std/time/struct.Duration.html#method.as_micros [`Duration::as_nanos`]: https://doc.rust-lang.org/std/time/struct.Duration.html#method.as_nanos [platform-support]: https://forge.rust-lang.org/platform-support.html

Remove the block on natvis for lld-link. Since rust-lang#56642 bumped minimum LLVM version to 6.0.0, Rust should be able to honor or ignore Windows natvis support with lld-link. It looks like llvm-mirror/lld@9133ca57b was in LLVM 7.0, while llvm-mirror/lld@27b9c4285 made it into 6.0, at least if the release branches are anything to go by. Fixes rust-lang#59383.

Pkgsrc changes: * Bump required rust version to build to 1.32.0. * Adapt patches to changed file locations. * Since we now patch some more vendor/ modules, doctor the corresponding .cargo-checksum.json files accordingly Upstream changes: Version 1.33.0 (2019-02-28) ========================== Language -------- - [You can now use the `cfg(target_vendor)` attribute.][57465] E.g. `#[cfg(target_vendor="apple")] fn main() { println!("Hello Apple!"); }` - [Integer patterns such as in a match expression can now be exhaustive.][56362] E.g. You can have match statement on a `u8` that covers `0..=255` and you would no longer be required to have a `_ => unreachable!()` case. - [You can now have multiple patterns in `if let` and `while let` expressions.][57532] You can do this with the same syntax as a `match` expression. E.g. ```rust enum Creature { Crab(String), Lobster(String), Person(String), } fn main() { let state = Creature::Crab("Ferris"); if let Creature::Crab(name) | Creature::Person(name) = state { println!("This creature's name is: {}", name); } } ``` - [You can now have irrefutable `if let` and `while let` patterns.][57535] Using this feature will by default produce a warning as this behaviour can be unintuitive. E.g. `if let _ = 5 {}` - [You can now use `let` bindings, assignments, expression statements, and irrefutable pattern destructuring in const functions.][57175] - [You can now call unsafe const functions.][57067] E.g. ```rust const unsafe fn foo() -> i32 { 5 } const fn bar() -> i32 { unsafe { foo() } } ``` - [You can now specify multiple attributes in a `cfg_attr` attribute.][57332] E.g. `#[cfg_attr(all(), must_use, optimize)]` - [You can now specify a specific alignment with the `#[repr(packed)]` attribute.][57049] E.g. `#[repr(packed(2))] struct Foo(i16, i32);` is a struct with an alignment of 2 bytes and a size of 6 bytes. - [You can now import an item from a module as an `_`.][56303] This allows you to import a trait's impls, and not have the name in the namespace. E.g. ```rust use std::io::Read as _; // Allowed as there is only one `Read` in the module. pub trait Read {} ``` - [You may now use `Rc`, `Arc`, and `Pin` as method receivers][56805]. Compiler -------- - [You can now set a linker flavor for `rustc` with the `-Clinker-flavor` command line argument.][56351] - [The mininum required LLVM version has been bumped to 6.0.][56642] - [Added support for the PowerPC64 architecture on FreeBSD.][57615] - [The `x86_64-fortanix-unknown-sgx` target support has been upgraded to tier 2 support.][57130] Visit the [platform support][platform-support] page for information on Rust's platform support. - [Added support for the `thumbv7neon-linux-androideabi` and `thumbv7neon-unknown-linux-gnueabihf` targets.][56947] - [Added support for the `x86_64-unknown-uefi` target.][56769] Libraries --------- - [The methods `overflowing_{add, sub, mul, shl, shr}` are now `const` functions for all numeric types.][57566] - [The methods `rotate_left`, `rotate_right`, and `wrapping_{add, sub, mul, shl, shr}` are now `const` functions for all numeric types.][57105] - [The methods `is_positive` and `is_negative` are now `const` functions for all signed numeric types.][57105] - [The `get` method for all `NonZero` types is now `const`.][57167] - [The methods `count_ones`, `count_zeros`, `leading_zeros`, `trailing_zeros`, `swap_bytes`, `from_be`, `from_le`, `to_be`, `to_le` are now `const` for all numeric types.][57234] - [`Ipv4Addr::new` is now a `const` function][57234] Stabilized APIs --------------- - [`unix::FileExt::read_exact_at`] - [`unix::FileExt::write_all_at`] - [`Option::transpose`] - [`Result::transpose`] - [`convert::identity`] - [`pin::Pin`] - [`marker::Unpin`] - [`marker::PhantomPinned`] - [`Vec::resize_with`] - [`VecDeque::resize_with`] - [`Duration::as_millis`] - [`Duration::as_micros`] - [`Duration::as_nanos`] Cargo ----- - [Cargo should now rebuild a crate if a file was modified during the initial build.][cargo/6484] Compatibility Notes ------------------- - The methods `str::{trim_left, trim_right, trim_left_matches, trim_right_matches}` are now deprecated in the standard library, and their usage will now produce a warning. Please use the `str::{trim_start, trim_end, trim_start_matches, trim_end_matches}` methods instead. - The `Error::cause` method has been deprecated in favor of `Error::source` which supports downcasting. [55982]: rust-lang/rust#55982 [56303]: rust-lang/rust#56303 [56351]: rust-lang/rust#56351 [56362]: rust-lang/rust#56362 [56642]: rust-lang/rust#56642 [56769]: rust-lang/rust#56769 [56805]: rust-lang/rust#56805 [56947]: rust-lang/rust#56947 [57049]: rust-lang/rust#57049 [57067]: rust-lang/rust#57067 [57105]: rust-lang/rust#57105 [57130]: rust-lang/rust#57130 [57167]: rust-lang/rust#57167 [57175]: rust-lang/rust#57175 [57234]: rust-lang/rust#57234 [57332]: rust-lang/rust#57332 [57465]: rust-lang/rust#57465 [57532]: rust-lang/rust#57532 [57535]: rust-lang/rust#57535 [57566]: rust-lang/rust#57566 [57615]: rust-lang/rust#57615 [cargo/6484]: rust-lang/cargo#6484 [`unix::FileExt::read_exact_at`]: https://doc.rust-lang.org/std/os/unix/fs/trait.FileExt.html#method.read_exact_at [`unix::FileExt::write_all_at`]: https://doc.rust-lang.org/std/os/unix/fs/trait.FileExt.html#method.write_all_at [`Option::transpose`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.transpose [`Result::transpose`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.transpose [`convert::identity`]: https://doc.rust-lang.org/std/convert/fn.identity.html [`pin::Pin`]: https://doc.rust-lang.org/std/pin/struct.Pin.html [`marker::Unpin`]: https://doc.rust-lang.org/stable/std/marker/trait.Unpin.html [`marker::PhantomPinned`]: https://doc.rust-lang.org/nightly/std/marker/struct.PhantomPinned.html [`Vec::resize_with`]: https://doc.rust-lang.org/std/vec/struct.Vec.html#method.resize_with [`VecDeque::resize_with`]: https://doc.rust-lang.org/std/collections/struct.VecDeque.html#method.resize_with [`Duration::as_millis`]: https://doc.rust-lang.org/std/time/struct.Duration.html#method.as_millis [`Duration::as_micros`]: https://doc.rust-lang.org/std/time/struct.Duration.html#method.as_micros [`Duration::as_nanos`]: https://doc.rust-lang.org/std/time/struct.Duration.html#method.as_nanos [platform-support]: https://forge.rust-lang.org/platform-support.html

rust-highfive assigned alexcrichton Dec 9, 2018

rust-highfive added the S-waiting-on-review label Dec 9, 2018

nikic mentioned this pull request Dec 9, 2018

Bump minimum LLVM version to LLVM 6 #55842

Closed

Bump minimum required LLVM version to 6.0

706e67b

nikic force-pushed the llvm-6 branch from ef0ad1c to 706e67b Compare December 9, 2018 11:06

bors added S-waiting-on-bors and removed S-waiting-on-review labels Dec 10, 2018

cuviper mentioned this pull request Dec 11, 2018

rustc: move debug info from LocalDecl and UpvarDecl into a dedicated VarDebugInfo. #56231

Merged

Remove env_alloca hack

6c2d704

This is no longer necessary for LLVM >= 6.

bors added S-waiting-on-review and removed S-waiting-on-bors labels Dec 16, 2018

bors added S-waiting-on-bors and removed S-waiting-on-review labels Dec 16, 2018

bors added S-waiting-on-review and removed S-waiting-on-bors labels Dec 16, 2018

bors added S-waiting-on-bors and removed S-waiting-on-review labels Dec 16, 2018

bors added S-waiting-on-review and removed S-waiting-on-bors labels Dec 17, 2018

bors added S-waiting-on-bors and removed S-waiting-on-review labels Dec 17, 2018

bors merged commit 6c2d704 into rust-lang:master Dec 17, 2018

This was referenced Dec 17, 2018

Add x86_64-musl as a host architecture #55163

Closed

[WIP] Bump system LLVM version to 7 #55176

Closed

Refactor rustc_codegen_ssa (part 2) #56636

Closed

rustc: Don't ICE on usage of two new target features #56908

Merged

cuviper added the relnotes label Jan 10, 2019

TheGoddessInari mentioned this pull request Mar 26, 2019

Remove the block on natvis for lld-link. #59441

Merged

Centril added this to the 1.33 milestone Apr 26, 2019

hanna-kruppe mentioned this pull request Sep 6, 2019

Migrate to LLVM{Get,Set}ValueName2 #64223

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump minimum required LLVM version to 6.0 #56642

Bump minimum required LLVM version to 6.0 #56642

nikic commented Dec 9, 2018

alexcrichton commented Dec 10, 2018

bors commented Dec 10, 2018

gnzlbg commented Dec 10, 2018

petrochenkov commented Dec 10, 2018 •

edited

Loading

gnzlbg commented Dec 10, 2018 •

edited

Loading

petrochenkov commented Dec 10, 2018

gnzlbg commented Dec 10, 2018

cuviper commented Dec 11, 2018

nikic commented Dec 11, 2018

bors commented Dec 11, 2018

bors commented Dec 16, 2018

bors commented Dec 16, 2018

kennytm commented Dec 16, 2018

bors commented Dec 16, 2018

pietroalbini commented Dec 16, 2018

bors commented Dec 16, 2018

pietroalbini commented Dec 16, 2018

bors commented Dec 16, 2018

bors commented Dec 17, 2018

rust-highfive commented Dec 17, 2018

kennytm commented Dec 17, 2018

bors commented Dec 17, 2018

bors commented Dec 17, 2018

Bump minimum required LLVM version to 6.0 #56642

Bump minimum required LLVM version to 6.0 #56642

Conversation

nikic commented Dec 9, 2018

alexcrichton commented Dec 10, 2018

bors commented Dec 10, 2018

gnzlbg commented Dec 10, 2018

petrochenkov commented Dec 10, 2018 • edited Loading

gnzlbg commented Dec 10, 2018 • edited Loading

petrochenkov commented Dec 10, 2018

gnzlbg commented Dec 10, 2018

cuviper commented Dec 11, 2018

nikic commented Dec 11, 2018

bors commented Dec 11, 2018

bors commented Dec 16, 2018

bors commented Dec 16, 2018

kennytm commented Dec 16, 2018

bors commented Dec 16, 2018

pietroalbini commented Dec 16, 2018

bors commented Dec 16, 2018

pietroalbini commented Dec 16, 2018

bors commented Dec 16, 2018

bors commented Dec 17, 2018

rust-highfive commented Dec 17, 2018

kennytm commented Dec 17, 2018

bors commented Dec 17, 2018

bors commented Dec 17, 2018

petrochenkov commented Dec 10, 2018 •

edited

Loading

gnzlbg commented Dec 10, 2018 •

edited

Loading