-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Remove some unnecessary feature gates #56708
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
Mostly LGTM For the 2 functions you removed, can you put |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Any particular reason? Can't you just |
Oh I didn't see it was a separate commit. Sure, that works. |
@bors: r+ |
📌 Commit 5457b19 has been approved by |
…, r=alexcrichton Remove some unnecessary feature gates fixes rust-lang#56585 cc @jethrogb
…, r=alexcrichton Remove some unnecessary feature gates fixes rust-lang#56585 cc @jethrogb
…, r=alexcrichton Remove some unnecessary feature gates fixes rust-lang#56585 cc @jethrogb
…, r=alexcrichton Remove some unnecessary feature gates fixes rust-lang#56585 cc @jethrogb
…, r=alexcrichton Remove some unnecessary feature gates fixes rust-lang#56585 cc @jethrogb
Rollup of 14 pull requests (first batch) Successful merges: - #56562 (Update libc version required by rustc) - #56609 (Unconditionally emit the target-cpu LLVM attribute.) - #56637 (rustdoc: Fix local reexports of proc macros) - #56658 (Add non-panicking `maybe_new_parser_from_file` variant) - #56695 (Fix irrefutable matches on integer ranges) - #56699 (Use a `newtype_index!` within `Symbol`.) - #56702 ([self-profiler] Add column for percent of total time) - #56708 (Remove some unnecessary feature gates) - #56709 (Remove unneeded extra chars to reduce search-index size) - #56744 (specialize: remove Boxes used by Children::insert) - #56748 (Update panic message to be clearer about env-vars) - #56749 (x86: Add the `adx` target feature to whitelist) - #56756 (Disable btree pretty-printers on older gdbs) - #56789 (rustc: Add an unstable `simd_select_bitmask` intrinsic) r? @ghost
fixes #56585
cc @jethrogb