-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Provide -isysroot with sdkroot for ios builds #56833
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Necessary for the new XCode?
@bors: r+ |
📌 Commit 313a9c7 has been approved by |
Provide -isysroot with sdkroot for ios builds Necessary for the new XCode? Absolutely positively definitely untested… although I did ``` cargo rustc -- -Clink-arg=-isysroot -Clink-arg=$sdk_root ``` and stuff did compile for once.
☀️ Test successful - status-appveyor, status-travis |
…elix Remove redundant `-Wl,-syslibroot` Since `-isysroot` is set, [Clang already passes this when invoking the linker](https://github.com/llvm/llvm-project/blob/llvmorg-17.0.6/clang/lib/Driver/ToolChains/Darwin.cpp#L439-L442). See rust-lang#56833 for when the `-isysroot` was originally added, but didn't remove the unnecessary linker flag. CC `@BlackHoleFox` r? shepmaster
Remove redundant `-Wl,-syslibroot` Since `-isysroot` is set, [Clang already passes this when invoking the linker](https://github.com/llvm/llvm-project/blob/llvmorg-17.0.6/clang/lib/Driver/ToolChains/Darwin.cpp#L439-L442). See rust-lang/rust#56833 for when the `-isysroot` was originally added, but didn't remove the unnecessary linker flag. CC `@BlackHoleFox` r? shepmaster
Remove redundant `-Wl,-syslibroot` Since `-isysroot` is set, [Clang already passes this when invoking the linker](https://github.com/llvm/llvm-project/blob/llvmorg-17.0.6/clang/lib/Driver/ToolChains/Darwin.cpp#L439-L442). See rust-lang/rust#56833 for when the `-isysroot` was originally added, but didn't remove the unnecessary linker flag. CC `@BlackHoleFox` r? shepmaster
Remove redundant `-Wl,-syslibroot` Since `-isysroot` is set, [Clang already passes this when invoking the linker](https://github.com/llvm/llvm-project/blob/llvmorg-17.0.6/clang/lib/Driver/ToolChains/Darwin.cpp#L439-L442). See rust-lang/rust#56833 for when the `-isysroot` was originally added, but didn't remove the unnecessary linker flag. CC `@BlackHoleFox` r? shepmaster
Necessary for the new XCode?
Absolutely positively definitely untested… although I did
and stuff did compile for once.