Add std::os::fortanix_sgx module
#56978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 19, 2018 11:53
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
jethrogb
commented
Dec 19, 2018
| @@ -40,7 +40,7 @@ rustc_tsan = { path = "../librustc_tsan" } | |||
| dlmalloc = { version = "0.1", features = ['rustc-dep-of-std'] } | |||
|
|
|||
| [target.x86_64-fortanix-unknown-sgx.dependencies] | |||
| fortanix-sgx-abi = { version = "0.3.1", features = ['rustc-dep-of-std'] } | |||
| fortanix-sgx-abi = { version = "0.3.2", features = ['rustc-dep-of-std'] } | |||
There was a problem hiding this comment.
Diff: fortanix/rust-sgx@769d806 (adding stability attributes)
jethrogb
commented
Dec 19, 2018
| @@ -63,4 +48,19 @@ cfg_if! { | |||
| } | |||
| } | |||
|
|
|||
| #[cfg(target_os = "android")] pub mod android; | |||
There was a problem hiding this comment.
These changes are from #56972
|
cc @jsakkine-intel |
|
I don't think it's reasonable for I would suggest calling this either (For clarity, I don't think it makes sense for any other ABI to get the name |
jethrogb
force-pushed
the
jb/sgx-os-mod
branch
from
8dc1c6a to
8a665ad
Compare
jethrogb
force-pushed
the
jb/sgx-os-mod
branch
from
8a665ad to
dcb5db8
Compare
|
Ok, changed to |
|
Thanks! @bors r+ |
|
📌 Commit dcb5db8 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Dec 24, 2018
Add `std::os::fortanix_sgx` module This PR adds the `std::os::sgx` module to expose platform-specific APIs behind the `sgx_platform` feature gate. Depends on rust-lang#56972 to be able to meaningfully build `std::os` documentation for non-standard targets. Tracking issue: rust-lang#56975
bors
added a commit
that referenced
this pull request
Dec 24, 2018
Rollup of 10 pull requests Successful merges: - #55470 (box: Add documentation for `From` impls) - #56242 (Add missing link in docs) - #56944 (bootstrap: Link LLVM as a dylib with ThinLTO) - #56978 (Add `std::os::fortanix_sgx` module) - #56985 (Allow testing pointers for inboundedness while forbidding dangling pointers) - #56986 (rustc: Move jemalloc from rustc_driver to rustc) - #57010 (Actually run compiletest tests on CI) - #57021 (Enable emission of alignment attrs for pointer params) - #57074 (Fix recursion limits) - #57085 (librustc_codegen_llvm: Don't eliminate empty structs in C ABI on linux-sparc64) Failed merges: r? @ghost
This was referenced Dec 25, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
std::os::sgxmodule to expose platform-specific APIs behind thesgx_platformfeature gate.Depends on #56972 to be able to meaningfully build
std::osdocumentation for non-standard targets.Tracking issue: #56975