-
Notifications
You must be signed in to change notification settings - Fork 13.4k
[do not merge] Revert "Convert SerializedDepGraph to be a struct-of-arrays" #57070
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
@bors try |
⌛ Trying commit ce7ee686c8d176013a8e3767c5a2d6a71cb9ba13 with merge 9db7021220dfbb6d33d8db1c1f1310a3bc4a1144... |
This comment has been minimized.
This comment has been minimized.
💔 Test failed - status-travis |
This comment has been minimized.
This comment has been minimized.
This reverts commit c43b1a0.
@bors try |
[do not merge] Revert "Convert SerializedDepGraph to be a struct-of-arrays" Let's check if #49069 was actually helpful. r? @michaelwoerister
☀️ Test successful - status-travis |
@rust-timer build d453555 |
Success: Queued d453555 with parent 2d3e909, comparison URL. |
Finished benchmarking try commit d453555 |
This doesn't seem to have much of an impact, but if it shifts computation to dep graph serialization it could still be beneficial to revert this for parallel queries. |
Let's check if #49069 was actually helpful.
r? @michaelwoerister