x.py: fixup 6130fc884bc1dff9bb835894a7bb2042c110b011, fix submodule handling #57082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors p=1 |
|
@pietroalbini could you p=2 (there's already a clippy update that has p=1 but it's less important imo) ^^ |
|
Right, didn't see that. The PR still has to be approved, so this might not be necessary. |
nikic
reviewed
Dec 23, 2018
|
Oh, whoops, I didn't notice that. It worked when I ran it locally, so, I didn't bother testing it further. Yeah, it should only be removed from the |
|
@bors r+ |
|
📌 Commit 4ad59b997979e481c57a2c87edd3c5c8e184dffb has been approved by |
bors
added
S-waiting-on-bors
|
@estebank isn't it better to wait until #57082 (comment) is done? |
|
@bors r- |
bors
added
S-waiting-on-author
matthiaskrgr
force-pushed
the
revert_56933
branch
from
4ad59b9 to
fc9a572
Compare
matthiaskrgr
changed the title
./x.py used to automatically check out the right commit when a submodule was outdated and ./x.py build was run and submodules handling was enabled in config.toml (submodules = true). But it threw an error: [...] failed to run: git submodule -q sync --progress src/tools/clippy The commit removes the --progress from git submodule call. Fixes rust-lang#57080
matthiaskrgr
force-pushed
the
revert_56933
branch
from
fc9a572 to
49eb1e5
Compare
|
I updated the PR to just fix the sync command. |
|
@bors r+ |
|
📌 Commit 49eb1e5 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Dec 24, 2018
x.py: fixup 6130fc8, fix submodule handling ./x.py used to automatically check out the right commit when a submodule was outdated and ./x.py build was run and submodules handling was enabled in config.toml (submodules = true). But it threw an error: [...] failed to run: git submodule -q sync --progress src/tools/clippy The commit removes the --progress from git submodule call. Fixes #57080
|
☀️ Test successful - status-appveyor, status-travis |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./x.py used to automatically check out the right commit when a submodule was outdated and ./x.py build was run
and submodules handling was enabled in config.toml (submodules = true).
But it threw an error:
[...]
failed to run: git submodule -q sync --progress src/tools/clippy
The commit removes the --progress from git submodule call.
Fixes #57080