-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Prepare everything for distributing miri via rustup #57086
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
@bors try |
⌛ Trying commit a808113 with merge c157742f7e2516794c540f2bba16c6a37ee8b417... |
☀️ Test successful - status-travis |
@oli-obk The dist doesn't seem successful. Is it expected?
|
This might be caused by #56924 not having landed yet. |
Marking this as "blocked" then. |
Miri has been updated, so this can proceed now. |
@bors retry |
Prepare everything for distributing miri via rustup r? @kennytm cc @RalfJung The next step is to tell rustup about `cargo-miri` in https://github.com/rust-lang/rustup.rs/blob/31935e5f633a5acd3a203d23b61d1556c64a821c/src/rustup/lib.rs#L28 and https://github.com/rust-lang/rustup.rs/blob/1ccd706d1d572c777c5134bd7db7aa1a8df7f278/src/rustup-win-installer/src/lib.rs#L29
💔 Test failed - status-travis |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
@bors r=kennytm |
📌 Commit d3894da has been approved by |
@bors r- winapi feature mismatch
|
@oli-obk you should add |
@bors r=kennytm |
📌 Commit 98a0224aa131ed504ef5163577a650c0f358b093 has been approved by |
🔒 Merge conflict This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again. How do I rebase?Assuming
You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial. Please avoid the "Resolve conflicts" button on GitHub. It uses Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Error message
|
Please rebase :( |
@bors r=kennytm |
📌 Commit 2ab78e1 has been approved by |
Prepare everything for distributing miri via rustup The next step is to tell rustup about `cargo-miri` in https://github.com/rust-lang/rustup.rs/blob/31935e5f633a5acd3a203d23b61d1556c64a821c/src/rustup/lib.rs#L28 and https://github.com/rust-lang/rustup.rs/blob/1ccd706d1d572c777c5134bd7db7aa1a8df7f278/src/rustup-win-installer/src/lib.rs#L29
☀️ Test successful - status-appveyor, status-travis |
The next step is to tell rustup about
cargo-miri
in https://github.com/rust-lang/rustup.rs/blob/31935e5f633a5acd3a203d23b61d1556c64a821c/src/rustup/lib.rs#L28 and https://github.com/rust-lang/rustup.rs/blob/1ccd706d1d572c777c5134bd7db7aa1a8df7f278/src/rustup-win-installer/src/lib.rs#L29