-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Make sure feature gate errors are recoverable (take 2) #57272
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
@bors r+ |
📌 Commit 2a02d6d has been approved by |
Make sure feature gate errors are recoverable (take 2) Continuation of rust-lang@15cefe4. Turns out I missed the most important part - the main feature gate checking pass.
Implement basic input validation for built-in attributes + Stabilize `unrestricted_attribute_tokens` Based on #57272 --- In accordance with the plan in https://internals.rust-lang.org/t/unrestricted-attribute-tokens-feature-status/8561: - The correct top-level shape (`#[attr]` vs `#[attr(...)]` vs `#[attr = ...]`) is enforced for built-in attributes. - For non-built-in non-macro attributes: - The key-value form is restricted to bare minimum required to support what we support on stable - unsuffixed literals (#34981). - Arbitrary token streams in remaining forms (`#[attr(token_stream)]`, `#[attr{token_stream}]`, `#[attr[token_stream]]` ) are now allowed without a feature gate, like in macro attributes. This will close #55208 once completed. Need to go through crater first.
☔ The latest upstream changes (presumably #56837) made this pull request unmergeable. Please resolve the merge conflicts. |
2a02d6d
to
d2aa83a
Compare
@bors r=estebank |
📌 Commit d2aa83aace77b4ac45315d5380dcfb9a738932af has been approved by |
⌛ Testing commit d2aa83aace77b4ac45315d5380dcfb9a738932af with merge ff579ef99a1c0162c16bcd6c23ece0e1756df5aa... |
💔 Test failed - status-travis |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
d2aa83a
to
3751177
Compare
@bors r=estebank |
📌 Commit 3751177 has been approved by |
Make sure feature gate errors are recoverable (take 2) Continuation of 15cefe4. Turns out I missed the most important part - the main feature gate checking pass.
☀️ Test successful - status-appveyor, status-travis |
Continuation of 15cefe4.
Turns out I missed the most important part - the main feature gate checking pass.