Rust 1.32.0 stable release #57600

pietroalbini · 2019-01-14T16:26:21Z

Also cherry-picked the following beta-accepted PRs:

Correct RELEASES.md for 1.32.0 #57519: Correct RELEASES.md for 1.32.0

r? @Mark-Simulacrum
cc @rust-lang/release

The `into_to_from_bytes` feature was stabilized for `i128` and `u128` just like for the other integer types, but they seem to have been missed.

rust-highfive · 2019-01-14T16:26:41Z

⚠️ Warning ⚠️

Pull requests are usually filed against the master branch for this repo, but this one is against stable. Please double check that you specified the right target!

Centril · 2019-01-14T16:31:10Z

@bors p=1000

Mark-Simulacrum · 2019-01-14T20:50:20Z

@bors r+ p=1000

bors · 2019-01-14T20:50:21Z

📌 Commit 04ccee1 has been approved by Mark-Simulacrum

bors · 2019-01-14T21:09:11Z

⌛ Testing commit 04ccee1 with merge 929d50aa4108695704c49860265558db30018560...

bors · 2019-01-14T23:00:43Z

💔 Test failed - status-appveyor

pietroalbini · 2019-01-14T23:16:00Z

Uh?

@bors retry

bors · 2019-01-15T01:42:05Z

⌛ Testing commit 04ccee1 with merge 1823a3189a3de2e08333027821e07e9d747a2df7...

bors · 2019-01-15T03:33:35Z

💔 Test failed - status-appveyor

Mark-Simulacrum · 2019-01-15T03:39:39Z

@alexcrichton Do you by chance know the .iss file syntax? Or maybe @retep998? I don't have the time to investigate tonight and am not quite sure what the problem is -- I suspect it has something to do with https://github.com/rust-lang/rust/blob/master/src/etc/installer/exe/rust.iss#L60 but haven't been able to determine yet if that's actually the problem or just a side effect.

Mark-Simulacrum · 2019-01-15T05:10:44Z

Well, all I've learned from the ~half hour of investigative work I did tonight is that I don't understand where these files are coming from. I also haven't found anything that changed since the last successful build of the parent commit from this PR -- i.e., https://ci.appveyor.com/project/rust-lang/rust/builds/21559614/job/6vmkp5fj047niib5 -- within the logs. We've bumped the toolchain to "stable" but that seems to be unrelated to the current failure. As far as I can tell, std is being built and disted -- even though I'm still not quite sure how the files make it into work here because as far as I could tell nothing is copying them there. Maybe I'm missing something though -- the dist code is quite convoluted; and in any case nothing has changed in all of bootstrap since the beta build was successful.

@alexcrichton said he'd do some more investigating tomorrow -- and I hope to spend at least a little time as well, though not sure how much I'll have.

bors · 2019-01-15T09:24:52Z

⌛ Testing commit 04ccee1 with merge 7a1d3dd80798d600bf3b17a42ce1e912894b1161...

kennytm · 2019-01-15T09:25:16Z

@bors r- retry

@Mark-Simulacrum

Rust 1.32.0 stable release Also cherry-picked the following beta-accepted PRs: * #57519: Correct RELEASES.md for 1.32.0 r? @Mark-Simulacrum cc @rust-lang/release

bors · 2019-01-16T03:23:32Z

💔 Test failed - status-appveyor

alexcrichton · 2019-01-16T03:28:55Z

@bors: treeclosed=9000

Fixes a bug in extracting a tarball by correctly recognizing entries are files instead of directories.

alexcrichton · 2019-01-16T06:22:09Z

@bors: r+

bors · 2019-01-16T06:22:10Z

📌 Commit 05fe2fc has been approved by alexcrichton

bors · 2019-01-16T06:22:10Z

🌲 The tree is currently closed for pull requests below priority 9000, this pull request will be tested once the tree is reopened

alexcrichton · 2019-01-16T06:22:23Z

@bors: p=10000

bors · 2019-01-16T06:22:23Z

🛑 Priority higher than 9001 is ignored.

alexcrichton · 2019-01-16T06:22:40Z

@bors: treeclosed-

bors · 2019-01-16T06:22:56Z

⌛ Testing commit 05fe2fc with merge e8f3130...

@Mark-Simulacrum

Rust 1.32.0 stable release Also cherry-picked the following beta-accepted PRs: * #57519: Correct RELEASES.md for 1.32.0 r? @Mark-Simulacrum cc @rust-lang/release

bors · 2019-01-16T09:24:05Z

💔 Test failed - checks-travis

rust-highfive · 2019-01-16T09:24:05Z

The job dist-x86_64-linux of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[02:58:18] [ 39%] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/FEntryInserter.cpp.o
[02:58:28] [ 40%] Building CXX object lib/CodeGen/SelectionDAG/CMakeFiles/LLVMSelectionDAG.dir/SelectionDAGTargetInfo.cpp.o
[02:58:39] [ 40%] Building CXX object lib/CodeGen/AsmPrinter/CMakeFiles/LLVMAsmPrinter.dir/DwarfAccelTable.cpp.o

Broadcast message from root@travis-job-befe3580-53b6-4135-8089-c1b3cf4a15db
 (unknown) at 9:23 ...
The system is going down for power off NOW!

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

kennytm · 2019-01-16T09:26:17Z

@bors retry

Repopulating cache

bors · 2019-01-16T09:28:42Z

⌛ Testing commit 05fe2fc with merge 9fda7c2...

@Mark-Simulacrum

Rust 1.32.0 stable release Also cherry-picked the following beta-accepted PRs: * #57519: Correct RELEASES.md for 1.32.0 r? @Mark-Simulacrum cc @rust-lang/release

bors · 2019-01-16T12:01:34Z

☀️ Test successful - checks-travis, status-appveyor
Approved by: alexcrichton
Pushing 9fda7c2 to stable...

pthariensflame and others added 3 commits January 14, 2019 17:19

Correct RELEASES.md for 1.32.0

a9ac964

The `into_to_from_bytes` feature was stabilized for `i128` and `u128` just like for the other integer types, but they seem to have been missed.

Fix new hyperlinks in RELEASES.md

d2b4fe0

stable 1.32.0 release

04ccee1

rust-highfive assigned Mark-Simulacrum Jan 14, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 14, 2019

pietroalbini added the T-release Relevant to the release subteam, which will review and decide on the PR/issue. label Jan 14, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 14, 2019

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 14, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 14, 2019

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 15, 2019

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 16, 2019

Update the tar crate

05fe2fc

Fixes a bug in extracting a tarball by correctly recognizing entries are files instead of directories.

alexcrichton force-pushed the stable-next branch from fe0fc3c to 05fe2fc Compare January 16, 2019 06:22

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 16, 2019

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 16, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 16, 2019

Centril mentioned this pull request Jan 16, 2019

rustc: Remove platform intrinsics crate #57416

Merged

bors merged commit 05fe2fc into stable Jan 16, 2019

Mark-Simulacrum deleted the stable-next branch January 16, 2019 16:22

Rust 1.32.0 stable release #57600

Rust 1.32.0 stable release #57600

Uh oh!

Conversation

pietroalbini commented Jan 14, 2019

Uh oh!

rust-highfive commented Jan 14, 2019

Uh oh!

Centril commented Jan 14, 2019

Uh oh!

Mark-Simulacrum commented Jan 14, 2019

Uh oh!

bors commented Jan 14, 2019

Uh oh!

bors commented Jan 14, 2019

Uh oh!

bors commented Jan 14, 2019

Uh oh!

pietroalbini commented Jan 14, 2019

Uh oh!

bors commented Jan 15, 2019

Uh oh!

bors commented Jan 15, 2019

Uh oh!

Mark-Simulacrum commented Jan 15, 2019

Uh oh!

Mark-Simulacrum commented Jan 15, 2019

Uh oh!

bors commented Jan 15, 2019

Uh oh!

kennytm commented Jan 15, 2019

Uh oh!

bors commented Jan 16, 2019

Uh oh!

alexcrichton commented Jan 16, 2019

Uh oh!

alexcrichton commented Jan 16, 2019

Uh oh!

bors commented Jan 16, 2019

Uh oh!

bors commented Jan 16, 2019

Uh oh!

alexcrichton commented Jan 16, 2019

Uh oh!

bors commented Jan 16, 2019

Uh oh!

alexcrichton commented Jan 16, 2019

Uh oh!

bors commented Jan 16, 2019

Uh oh!

bors commented Jan 16, 2019

Uh oh!

rust-highfive commented Jan 16, 2019

Uh oh!

kennytm commented Jan 16, 2019

Uh oh!

bors commented Jan 16, 2019

Uh oh!

bors commented Jan 16, 2019

Uh oh!

Uh oh!