-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Conditionally skip two passes if their related attributes were not found #57691
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
☔ The latest upstream changes (presumably #57869) made this pull request unmergeable. Please resolve the merge conflicts. |
AST validation is supposed to work on the "final" AST and check that internal expansion passes don't produce anything suspicious either. Beside that collecting flags for later passes seems "off-topic" for AST validation. Still seems ok, other passes are even less suitable for collecting the flags for this optimization. |
📌 Commit c8f51324b5789e7dd3e8f9a923dc4a350a24f1a4 has been approved by |
🔒 Merge conflict This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again. How do I rebase?Assuming
You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial. Please avoid the "Resolve conflicts" button on GitHub. It uses Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Error message
|
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
@bors r=petrochenkov |
📌 Commit cfe6544 has been approved by |
Conditionally skip two passes if their related attributes were not found
🔒 Merge conflict This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again. How do I rebase?Assuming
You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial. Please avoid the "Resolve conflicts" button on GitHub. It uses Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Error message
|
@bors r=petrochenkov |
📌 Commit 1bdd2f6 has been approved by |
Conditionally skip two passes if their related attributes were not found
☀️ Test successful - checks-travis, status-appveyor |
☀️ Test successful - checks-travis, status-appveyor |
No description provided.