Rollup of 4 pull requests #57991
Closed
Rollup of 4 pull requests #57991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The functions return a reference to a new object and do not modify in-place
as the following code shows:
````
let s = String::from(" hello ");
s.trim();
assert_eq!(s, " hello ");
````
The new reference should be bound to a variable as now indicated by #[must_use].
trimmed string is returned as a slice instead of a new allocation Co-Authored-By: matthiaskrgr <matthias.krueger@famsik.de>
…eses-in-match-with-comma, r=oli-obk suggest `|` when `,` founds in invalid match value Issue rust-lang#54807 I get stuck on (what | how) I should implement...
Mark str::trim.* functions as #[must_use].
The functions return a reference to a new object and do not modify in-place
as the following code shows:
````
let s = String::from(" hello ");
s.trim();
assert_eq!(s, " hello ");
````
The new reference should be bound to a variable as now indicated by #[must_use].
…mulacrum use `SOURCE_DATE_EPOCH` for man page time if set Fixes rust-lang#57776.
…alexcrichton Introduce into_raw_non_null on Rc and Arc None
|
@bors r+ p=4 |
|
📌 Commit e9de86c has been approved by |
bors
added
the
S-waiting-on-bors
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
|when,founds in invalid match value #57008 (suggest|when,founds in invalid match value)SOURCE_DATE_EPOCHfor man page time if set #57920 (useSOURCE_DATE_EPOCHfor man page time if set)Failed merges:
r? @ghost