Transition build-manifest to 2018 edition #58113

h-michael · 2019-02-03T15:06:33Z

rust-highfive · 2019-02-03T15:06:43Z

(rust_highfive has picked a reviewer for you, use r? to override)

alexcrichton · 2019-02-04T07:26:17Z

Thanks!

Would you be up for deleting extern crate serde_derive as well? We should be able to activate the derive feature of serde and then use serde::Deserialize for derive I think

h-michael · 2019-02-04T16:16:07Z

@alexcrichton Thanks for your review.
All of your review is surely for me :)

alexcrichton · 2019-02-04T19:56:51Z

Thanks! Could you be sure to update the dependency in Cargo.toml to enable the derive feature of the serde crate as well?

h-michael · 2019-02-05T00:37:38Z

Updated. Is this what you mean? :)

rust-highfive · 2019-02-05T00:41:19Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:01f50d83:start=1549327025090644957,finish=1549327124371093622,duration=99280448665
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
####################################################################      94.6%
######################################################################## 100.0%
[00:01:58] extracting /checkout/obj/build/cache/2019-01-18/cargo-beta-x86_64-unknown-linux-gnu.tar.gz
[00:01:58]     Updating crates.io index
[00:02:09] error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
[00:02:09] Build completed unsuccessfully in 0:00:30
[00:02:09] Makefile:70: recipe for target 'prepare' failed
[00:02:09] make: *** [prepare] Error 1
[00:02:10] Command failed. Attempt 2/5:
[00:02:10] Command failed. Attempt 2/5:
[00:02:11] error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
[00:02:11] Build completed unsuccessfully in 0:00:00
[00:02:11] make: *** [prepare] Error 1
[00:02:11] Makefile:70: recipe for target 'prepare' failed
[00:02:13] Command failed. Attempt 3/5:
[00:02:13] Command failed. Attempt 3/5:
[00:02:13] error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
[00:02:13] Build completed unsuccessfully in 0:00:00
[00:02:13] make: *** [prepare] Error 1
[00:02:13] Makefile:70: recipe for target 'prepare' failed
[00:02:16] Command failed. Attempt 4/5:
[00:02:16] Command failed. Attempt 4/5:
[00:02:16] error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
[00:02:16] Build completed unsuccessfully in 0:00:00
[00:02:16] make: *** [prepare] Error 1
[00:02:16] Makefile:70: recipe for target 'prepare' failed
[00:02:20] Command failed. Attempt 5/5:
[00:02:20] Command failed. Attempt 5/5:
[00:02:21] error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
[00:02:21] Build completed unsuccessfully in 0:00:00
[00:02:21] Makefile:70: recipe for target 'prepare' failed
[00:02:21] The command has failed after 5 attempts.
[00:02:21] make: *** [prepare] Error 1
---
travis_time:end:0eea3300:start=1549327276648467364,finish=1549327276655192721,duration=6725357
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:01178f9e
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0442741c
travis_time:start:0442741c
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:05dcf59a
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2019-02-05T00:52:41Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:07d1c0c0:start=1549327781830796393,finish=1549327784092907159,duration=2262110766
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
[00:02:00] 
######################################################################## 100.0%
[00:02:01] extracting /checkout/obj/build/cache/2019-01-18/cargo-beta-x86_64-unknown-linux-gnu.tar.gz
[00:02:01]     Updating crates.io index
[00:02:12] error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
[00:02:12] Build completed unsuccessfully in 0:00:45
[00:02:12] make: *** [prepare] Error 1
[00:02:12] Makefile:70: recipe for target 'prepare' failed
[00:02:13] Command failed. Attempt 2/5:
[00:02:13] Command failed. Attempt 2/5:
[00:02:14] error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
[00:02:14] Build completed unsuccessfully in 0:00:00
[00:02:14] make: *** [prepare] Error 1
[00:02:14] Makefile:70: recipe for target 'prepare' failed
[00:02:16] Command failed. Attempt 3/5:
[00:02:16] Command failed. Attempt 3/5:
[00:02:16] error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
[00:02:16] Build completed unsuccessfully in 0:00:00
[00:02:16] make: *** [prepare] Error 1
[00:02:16] Makefile:70: recipe for target 'prepare' failed
[00:02:19] Command failed. Attempt 4/5:
[00:02:19] Command failed. Attempt 4/5:
[00:02:20] error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
[00:02:20] Build completed unsuccessfully in 0:00:00
[00:02:20] make: *** [prepare] Error 1
[00:02:20] Makefile:70: recipe for target 'prepare' failed
[00:02:24] Command failed. Attempt 5/5:
[00:02:24] Command failed. Attempt 5/5:
[00:02:24] error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
[00:02:24] Build completed unsuccessfully in 0:00:00
[00:02:24] make: *** [prepare] Error 1
[00:02:24] Makefile:70: recipe for target 'prepare' failed
[00:02:24] The command has failed after 5 attempts.
---
travis_time:end:056d8773:start=1549327943073963426,finish=1549327943079472325,duration=5508899
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:310a448f
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0211c483
travis_time:start:0211c483
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:003361dc
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2019-02-05T01:05:26Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:0383b44c:start=1549328460559988277,finish=1549328463223886563,duration=2663898286
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
###################################################                       71.7%
######################################################################## 100.0%
[00:02:08] extracting /checkout/obj/build/cache/2019-01-18/cargo-beta-x86_64-unknown-linux-gnu.tar.gz
[00:02:08]     Updating crates.io index
[00:02:19] error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
[00:02:19] Build completed unsuccessfully in 0:00:24
[00:02:19] Makefile:70: recipe for target 'prepare' failed
[00:02:19] make: *** [prepare] Error 1
[00:02:20] Command failed. Attempt 2/5:
[00:02:20] Command failed. Attempt 2/5:
[00:02:21] error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
[00:02:21] Build completed unsuccessfully in 0:00:00
[00:02:21] make: *** [prepare] Error 1
[00:02:21] Makefile:70: recipe for target 'prepare' failed
[00:02:23] Command failed. Attempt 3/5:
[00:02:23] Command failed. Attempt 3/5:
[00:02:23] error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
[00:02:23] Build completed unsuccessfully in 0:00:00
[00:02:23] Makefile:70: recipe for target 'prepare' failed
[00:02:23] make: *** [prepare] Error 1
[00:02:26] Command failed. Attempt 4/5:
[00:02:26] Command failed. Attempt 4/5:
[00:02:26] error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
[00:02:26] Build completed unsuccessfully in 0:00:00
[00:02:26] Makefile:70: recipe for target 'prepare' failed
[00:02:26] make: *** [prepare] Error 1
[00:02:30] Command failed. Attempt 5/5:
[00:02:30] Command failed. Attempt 5/5:
[00:02:31] error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
[00:02:31] Build completed unsuccessfully in 0:00:00
[00:02:31] make: *** [prepare] Error 1
[00:02:31] Makefile:70: recipe for target 'prepare' failed
[00:02:31] The command has failed after 5 attempts.
---
travis_time:end:01c245e7:start=1549328627876977142,finish=1549328627881643611,duration=4666469
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:1d17bd68
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:11a56ecb
travis_time:start:11a56ecb
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:1a6507a2
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

alexcrichton · 2019-02-05T05:54:40Z

@bors: r+

Thanks!

bors · 2019-02-05T05:54:41Z

📌 Commit 47a587f has been approved by alexcrichton

…excrichton Transition build-manifest to 2018 edition rust-lang#58099

@ghost

Rollup of 23 pull requests Successful merges: - #58001 (proc_macro: make `TokenStream::from_streams` pre-allocate its vector.) - #58096 (Transition linkchecker to 2018 edition) - #58097 (Transition remote test to Rust 2018) - #58106 (libfmt_macros => 2018) - #58107 (libgraphviz => 2018) - #58108 (Add NVPTX target to a build manifest) - #58109 (librustc_privacy => 2018) - #58112 (libpanic_abort => 2018) - #58113 (Transition build-manifest to 2018 edition) - #58114 (Transition tidy and unstable-book-gen to 2018 edition) - #58116 (Include the span of attributes of the lhs to the span of the assignment expression) - #58117 (Transition rustdoc-theme to 2018 edition) - #58128 (libunwind => 2018) - #58138 (Fix #58101) - #58139 (hir: add more HirId methods) - #58141 (Remove weasel word in docs for iter's take_while()) - #58142 (Remove stray FIXME) - #58145 (Add #[must_use] to core::task::Poll) - #58162 (Add more debugging code to track down appveyor 259 exit code) - #58169 (Update contributor name in .mailmap) - #58172 (update split docs) - #58182 (SGX target: handle empty user buffers correctly) - #58186 (Add Rustlings to the doc index) Failed merges: r? @ghost

rust-highfive assigned alexcrichton Feb 3, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 3, 2019

Centril mentioned this pull request Feb 3, 2019

Tracking issue for Transitioning crates to Rust 2018 #58099

Closed

78 tasks

h-michael added 2 commits February 5, 2019 09:48

Transition build-manifest to 2018 edition

5d9eed4

Remove macro_use

212533a

h-michael added 2 commits February 5, 2019 10:51

Use derive feature of serde

6904fac

Remove unncessary return statement

47a587f

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 5, 2019

kennytm added a commit to kennytm/rust that referenced this pull request Feb 5, 2019

Rollup merge of rust-lang#58113 - h-michael:build-manifest-2018, r=al…

b9def8e

…excrichton Transition build-manifest to 2018 edition rust-lang#58099

kennytm mentioned this pull request Feb 5, 2019

Rollup of 23 pull requests #58189

Merged

bors merged commit 47a587f into rust-lang:master Feb 5, 2019

h-michael deleted the build-manifest-2018 branch February 6, 2019 02:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Transition build-manifest to 2018 edition #58113

Transition build-manifest to 2018 edition #58113

h-michael commented Feb 3, 2019

rust-highfive commented Feb 3, 2019

alexcrichton commented Feb 4, 2019

h-michael commented Feb 4, 2019

alexcrichton commented Feb 4, 2019

h-michael commented Feb 5, 2019

rust-highfive commented Feb 5, 2019

rust-highfive commented Feb 5, 2019

rust-highfive commented Feb 5, 2019

alexcrichton commented Feb 5, 2019

bors commented Feb 5, 2019

Transition build-manifest to 2018 edition #58113

Transition build-manifest to 2018 edition #58113

Conversation

h-michael commented Feb 3, 2019

rust-highfive commented Feb 3, 2019

alexcrichton commented Feb 4, 2019

h-michael commented Feb 4, 2019

alexcrichton commented Feb 4, 2019

h-michael commented Feb 5, 2019

rust-highfive commented Feb 5, 2019

rust-highfive commented Feb 5, 2019

rust-highfive commented Feb 5, 2019

alexcrichton commented Feb 5, 2019

bors commented Feb 5, 2019