Don't apply impl block collapse rules to trait impls #58150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
Manishearth
approved these changes
Feb 7, 2019
src/librustdoc/html/static/main.js
Outdated
| @@ -1974,7 +1974,7 @@ if (!DOMTokenList.prototype.remove) { | |||
| } | |||
| } | |||
| } else { | |||
| // we are collapsing the impl block | |||
| // we are collapsing the impl block(s?). | |||
GuillaumeGomez
force-pushed
the
dont-apply-impl-collapse-rules-to-trait-impls
branch
from
08705a0 to
729e37d
Compare
|
@bors: r=Manishearth |
|
📌 Commit 729e37d has been approved by |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Feb 7, 2019
…apse-rules-to-trait-impls, r=Manishearth Don't apply impl block collapse rules to trait impls Fixes rust-lang#58147. r? @QuietMisdreavus
bors
added a commit
that referenced
this pull request
Feb 7, 2019
Rollup of 11 pull requests Successful merges: - #57504 (Re-enable history api on file:// protocol) - #57848 (Generate a documentation page for core::mem::transmute.) - #57884 (Update minifier version) - #57954 (rustdoc: remove blank unstable spans) - #58028 (Fix image link in the settings menu) - #58033 (rustdoc: wrap stability tags in colored spans) - #58086 ([rustdoc] Improve file list display) - #58143 (Sort elements in the sidebar) - #58146 (Prevent automatic collapse of methods impl blocks) - #58150 (Don't apply impl block collapse rules to trait impls) - #58185 (Remove images' url to make it work even without internet connection) Failed merges: r? @ghost
GuillaumeGomez
deleted the
dont-apply-impl-collapse-rules-to-trait-impls
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58147.
r? @QuietMisdreavus